[coreboot-gerrit] Patch merged into coreboot/master: 85836c2 superio: Use 'pnp_devfn_t' over 'device_t' in romstage component

gerrit at coreboot.org gerrit at coreboot.org
Mon Oct 27 12:50:38 CET 2014


the following patch was just integrated into master:
commit 85836c2215498ff18746b3a7e85ed684cf2e119e
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Wed Jul 9 20:26:25 2014 +1000

    superio: Use 'pnp_devfn_t' over 'device_t' in romstage component
    
    The romstage component of Super I/O support is in fact written around
    passing a lower and upper half packed integer. We currently have two
    typedef's for this, 'device_t' and 'pnp_devfn_t'. We wish to make use of
    'pnp_devfn_t' over 'device_t' as 'device_t' changes it's typedef in the
    ramstage context and so is really a conflicting definition. This helps
    solve problems down the road to having the 'real' 'device_t' definition
    usable in romstage later.
    
    This follows on from the rational given in:
    c2956e7 device/pci_early.c: Mixes up variants of a typedefs to 'u32'
    
    Change-Id: Ia9f238ebb944f9fe7b274621ee0c09a6de288a76
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Reviewed-on: http://review.coreboot.org/6231
    Reviewed-by: Nico Huber <nico.h at gmx.de>
    Tested-by: build bot (Jenkins)


See http://review.coreboot.org/6231 for details.

-gerrit



More information about the coreboot-gerrit mailing list