[coreboot-gerrit] Patch merged into coreboot/master: c186966 mainboards/asrock/e350m1: Use driver for Nuvoton NCT5572D superio chip

gerrit at coreboot.org gerrit at coreboot.org
Thu Oct 30 11:41:31 CET 2014


the following patch was just integrated into master:
commit c1869666f0904fe78c72265b44b46d1fc9f75a59
Author: Felix Held <felix-coreboot at felixheld.de>
Date:   Sat Jul 19 00:21:43 2014 +0200

    mainboards/asrock/e350m1: Use driver for Nuvoton NCT5572D superio chip
    
    On the ASRock E350M1 a Nuvoton NCT5572D is used as SuperIO-chip. The coreboot
    port to this board however used the driver of the Winbond W83627HF SuperIO,
    which is compatible enough to get most stuff working, but which clears bit 6 in
    register 0x2B. This switches the function of pin 38 of the NCT5572D from
    RSTOUT1# output to GP36. The PERST# pin of the ethernet chip and the
    unpopulated miniPCIe slot are connected to this pin, so they didn't get reset
    during a reboot.
    
    Using the newly added driver for the Nuvoton NCT5572D fixes this problem.
    
    There is also a trace from the pin 37 of the SuperIO, which can be configured
    as RSTOUT2#, to pin 82 of the USB3-chip with unknown function.
    
    As with the wrong driver, PS/2 keyboard and mouse do work in SeaBIOS and GRUB
    but not in Linux.
    
    Change-Id: I4bc78406afd3b0e10a1b04b561147e0ed94cc494
    Signed-off-by: Felix Held <felix-coreboot at felixheld.de>
    Reviewed-on: http://review.coreboot.org/6266
    Reviewed-by: Nicolas Reinecke <nr at das-labor.org>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Nico Huber <nico.h at gmx.de>


See http://review.coreboot.org/6266 for details.

-gerrit



More information about the coreboot-gerrit mailing list