[coreboot-gerrit] Patch set updated for coreboot: ae0270d mainboard: Use DEVICE_NOOP macro over dummy symbol

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Fri Oct 31 00:27:56 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7286

-gerrit

commit ae0270d912fae624578b61a2a68cc9a76a4c367a
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Oct 31 08:04:30 2014 +1100

    mainboard: Use DEVICE_NOOP macro over dummy symbol
    
    Change-Id: I37c302c7a17645f55d568c1a5f7bb791319ddbb4
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/emulation/qemu-i440fx/northbridge.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c
index 0f8c0c2..2714052 100644
--- a/src/mainboard/emulation/qemu-i440fx/northbridge.c
+++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c
@@ -262,14 +262,10 @@ static unsigned int cpu_bus_scan(device_t bus, unsigned int max)
 	return max_cpus;
 }
 
-static void cpu_bus_noop(device_t dev)
-{
-}
-
 static struct device_operations cpu_bus_ops = {
-	.read_resources   = cpu_bus_noop,
-	.set_resources    = cpu_bus_noop,
-	.enable_resources = cpu_bus_noop,
+	.read_resources   = DEVICE_NOOP,
+	.set_resources    = DEVICE_NOOP,
+	.enable_resources = DEVICE_NOOP,
 	.init             = cpu_bus_init,
 	.scan_bus         = cpu_bus_scan,
 };



More information about the coreboot-gerrit mailing list