[coreboot-gerrit] Patch set updated for coreboot: 61d9ecb {cpu, soc}: Use DEVICE_NOOP macro over dummy symbol
Edward O'Callaghan (eocallaghan@alterapraxis.com)
gerrit at coreboot.org
Fri Oct 31 00:28:10 CET 2014
Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7285
-gerrit
commit 61d9ecb84f078dbe46ea8647bbc992ad535c4518
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Fri Oct 31 08:03:16 2014 +1100
{cpu,soc}: Use DEVICE_NOOP macro over dummy symbol
Change-Id: Iaf2b2873bd1c52d7f936bd9b483e194a0872a626
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
src/cpu/allwinner/a10/cpu.c | 8 ++------
src/cpu/amd/sc520/sc520.c | 13 +++----------
src/soc/intel/baytrail/chip.c | 8 +++-----
src/soc/intel/broadwell/chip.c | 8 +++-----
src/soc/intel/fsp_baytrail/chip.c | 8 +++-----
src/soc/nvidia/tegra124/soc.c | 8 ++------
src/soc/samsung/exynos5250/cpu.c | 8 ++------
src/soc/samsung/exynos5420/cpu.c | 8 ++------
8 files changed, 20 insertions(+), 49 deletions(-)
diff --git a/src/cpu/allwinner/a10/cpu.c b/src/cpu/allwinner/a10/cpu.c
index fac5730..3159f20 100644
--- a/src/cpu/allwinner/a10/cpu.c
+++ b/src/cpu/allwinner/a10/cpu.c
@@ -25,13 +25,9 @@ static void cpu_init(struct device *dev)
/* TODO: Check if anything else needs to be explicitly initialized */
}
-static void cpu_noop(struct device *dev)
-{
-}
-
static struct device_operations cpu_ops = {
- .read_resources = cpu_noop,
- .set_resources = cpu_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
.enable_resources = cpu_enable_resources,
.init = cpu_init,
.scan_bus = NULL,
diff --git a/src/cpu/amd/sc520/sc520.c b/src/cpu/amd/sc520/sc520.c
index 808c33c..0521544 100644
--- a/src/cpu/amd/sc520/sc520.c
+++ b/src/cpu/amd/sc520/sc520.c
@@ -44,9 +44,6 @@ static void sc520_enable_resources(struct device *dev) {
pci_write_config8(dev, PCI_COMMAND, command);
command = pci_read_config8(dev, PCI_COMMAND);
printk(BIOS_SPEW, "========>%s, command 0x%x\n", __func__, command);
-/*
- */
-
}
static void sc520_read_resources(device_t dev)
@@ -170,14 +167,10 @@ static void cpu_bus_init(device_t dev)
printk(BIOS_SPEW, "cpu_bus_init\n");
}
-static void cpu_bus_noop(device_t dev)
-{
-}
-
static struct device_operations cpu_bus_ops = {
- .read_resources = cpu_bus_noop,
- .set_resources = cpu_bus_noop,
- .enable_resources = cpu_bus_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};
diff --git a/src/soc/intel/baytrail/chip.c b/src/soc/intel/baytrail/chip.c
index ce9eb49..7a5b9c2 100644
--- a/src/soc/intel/baytrail/chip.c
+++ b/src/soc/intel/baytrail/chip.c
@@ -40,12 +40,10 @@ static struct device_operations pci_domain_ops = {
.ops_pci_bus = pci_bus_default_ops,
};
-static void cpu_bus_noop(device_t dev) { }
-
static struct device_operations cpu_bus_ops = {
- .read_resources = cpu_bus_noop,
- .set_resources = cpu_bus_noop,
- .enable_resources = cpu_bus_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = baytrail_init_cpus,
.scan_bus = NULL,
};
diff --git a/src/soc/intel/broadwell/chip.c b/src/soc/intel/broadwell/chip.c
index 94f7893..2a12820 100644
--- a/src/soc/intel/broadwell/chip.c
+++ b/src/soc/intel/broadwell/chip.c
@@ -36,12 +36,10 @@ static struct device_operations pci_domain_ops = {
.ops_pci_bus = &pci_ops_mmconf,
};
-static void cpu_bus_noop(device_t dev) { }
-
static struct device_operations cpu_bus_ops = {
- .read_resources = &cpu_bus_noop,
- .set_resources = &cpu_bus_noop,
- .enable_resources = &cpu_bus_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = &broadwell_init_cpus,
};
diff --git a/src/soc/intel/fsp_baytrail/chip.c b/src/soc/intel/fsp_baytrail/chip.c
index 839e8dc..732d1dc 100644
--- a/src/soc/intel/fsp_baytrail/chip.c
+++ b/src/soc/intel/fsp_baytrail/chip.c
@@ -50,12 +50,10 @@ static struct device_operations pci_domain_ops = {
.ops_pci_bus = pci_bus_default_ops,
};
-static void cpu_bus_noop(device_t dev) { }
-
static struct device_operations cpu_bus_ops = {
- .read_resources = cpu_bus_noop,
- .set_resources = cpu_bus_noop,
- .enable_resources = cpu_bus_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = baytrail_init_cpus,
.scan_bus = NULL,
};
diff --git a/src/soc/nvidia/tegra124/soc.c b/src/soc/nvidia/tegra124/soc.c
index 11a52c4..8ad1aa9 100644
--- a/src/soc/nvidia/tegra124/soc.c
+++ b/src/soc/nvidia/tegra124/soc.c
@@ -45,13 +45,9 @@ static void soc_init(device_t dev)
printk(BIOS_INFO, "CPU: Tegra124\n");
}
-static void soc_noop(device_t dev)
-{
-}
-
static struct device_operations soc_ops = {
- .read_resources = soc_noop,
- .set_resources = soc_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
.enable_resources = soc_enable,
.init = soc_init,
.scan_bus = 0,
diff --git a/src/soc/samsung/exynos5250/cpu.c b/src/soc/samsung/exynos5250/cpu.c
index b8b88d7..60fa55a 100644
--- a/src/soc/samsung/exynos5250/cpu.c
+++ b/src/soc/samsung/exynos5250/cpu.c
@@ -129,13 +129,9 @@ static void cpu_init(device_t dev)
cpu_id, get_arm_clk() / (1024*1024));
}
-static void cpu_noop(device_t dev)
-{
-}
-
static struct device_operations cpu_ops = {
- .read_resources = cpu_noop,
- .set_resources = cpu_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
.enable_resources = cpu_enable,
.init = cpu_init,
.scan_bus = 0,
diff --git a/src/soc/samsung/exynos5420/cpu.c b/src/soc/samsung/exynos5420/cpu.c
index 506b676..c904636 100644
--- a/src/soc/samsung/exynos5420/cpu.c
+++ b/src/soc/samsung/exynos5420/cpu.c
@@ -160,13 +160,9 @@ static void cpu_init(device_t dev)
cpu_id, get_arm_clk() / 1000000);
}
-static void cpu_noop(device_t dev)
-{
-}
-
static struct device_operations cpu_ops = {
- .read_resources = cpu_noop,
- .set_resources = cpu_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
.enable_resources = cpu_enable,
.init = cpu_init,
.scan_bus = 0,
More information about the coreboot-gerrit
mailing list