[coreboot-gerrit] New patch to review for coreboot: 0f3bb9b roda/rk886ex: Move dummy DCC ON# to finalize stage

[Stefan Reinauer (stefan.reinauer@coreboot.org)]

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6845

-gerrit

commit 0f3bb9bd7bb8e86b3c965d04facc9e51b18997ae
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Fri Sep 5 23:53:39 2014 +0200

    roda/rk886ex: Move dummy DCC ON# to finalize stage
    
    During Vladimir's ACPI cleanups, this was moved into the mainboard's
    enable stage, which will prevent the VGA option rom from executing
    correctly. Move it to the finalize stage to make sure it runs after
    all initialize functions have been called.
    
    Change-Id: I0fcca4d4a95f89382f377ce923f82ecb71467fd8
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/mainboard/roda/rk886ex/mainboard.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/roda/rk886ex/mainboard.c b/src/mainboard/roda/rk886ex/mainboard.c
index ba7ed23..4c7fffa 100644
--- a/src/mainboard/roda/rk886ex/mainboard.c
+++ b/src/mainboard/roda/rk886ex/mainboard.c
@@ -63,6 +63,13 @@ static void dump_runtime_registers(void)
 }
 #endif
 
+static void mainboard_final(device_t dev)
+{
+	/* Enable Dummy DCC ON# for DVI */
+	printk(BIOS_DEBUG, "Laptop handling...\n");
+	outb(inb(0x60f) & ~(1 << 5), 0x60f);
+}
+
 static void mainboard_enable(device_t dev)
 {
 	/* Configure the MultiKey controller */
@@ -81,9 +88,8 @@ static void mainboard_enable(device_t dev)
 #if DUMP_RUNTIME_REGISTERS
 	dump_runtime_registers();
 #endif
-	/* Enable Dummy DCC ON# for DVI */
-	printk(BIOS_DEBUG, "Laptop handling...\n");
-	outb(inb(0x60f) & ~(1 << 5), 0x60f);
+
+	dev->ops->final = mainboard_final;
 }
 
 struct chip_operations mainboard_ops = {