[coreboot-gerrit] Patch merged into coreboot/master: 34e7615 romcc: avoid use-after-free

gerrit at coreboot.org gerrit at coreboot.org
Sat Sep 6 09:21:09 CEST 2014


the following patch was just integrated into master:
commit 34e76152351a9c846d850064990a37e3d453d97f
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Fri Sep 5 23:54:04 2014 +0200

    romcc: avoid use-after-free
    
    Windows bugchecks on this for a while, so we ifndef'd the free() call out.
    Now some Linuxes (depending on their glibc) also fail on it, so just
    remove the call altogether at the cost of some leaked memory (couple
    hundred kilobytes) because tracking down the precise fix is too hard.
    
    In case someone wants to fix it, valgrind sees the issues, so
    revert this change and work on romcc's memory management until valgrind
    is happy.
    To get a fix in, provide a good explanation why your change is actually
    the right way to fix it - for silencing valgrind, this change will do.
    
    Change-Id: Iae3f847e09a0d7bcb8bb4f50983a1b0727570b23
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Reviewed-on: http://review.coreboot.org/6846
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Tested-by: build bot (Jenkins)


See http://review.coreboot.org/6846 for details.

-gerrit



More information about the coreboot-gerrit mailing list