[coreboot-gerrit] New patch to review for coreboot: 174746b lenovo/t530: Apply ME workaround for S3 resume

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Thu Sep 11 20:08:43 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6876

-gerrit

commit 174746b445baef5c347c7f32c06ac74b386e126b
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Sep 12 03:53:43 2014 +1000

    lenovo/t530: Apply ME workaround for S3 resume
    
    Upon S3 resume, the machine powers off due to the ME not being awake yet.
    
    Change-Id: I0255dd0fa6b4cb3b539e11a69a618c770c44f4b0
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/lenovo/t530/acpi/platform.asl | 4 ++++
 src/mainboard/lenovo/t530/dsdt.asl          | 1 +
 2 files changed, 5 insertions(+)

diff --git a/src/mainboard/lenovo/t530/acpi/platform.asl b/src/mainboard/lenovo/t530/acpi/platform.asl
index 5466bed..72b9dbf 100644
--- a/src/mainboard/lenovo/t530/acpi/platform.asl
+++ b/src/mainboard/lenovo/t530/acpi/platform.asl
@@ -68,6 +68,10 @@ Method(_PTS,1)
 
 Method(_WAK,1)
 {
+	/* ME may not be up yet.  */
+	Store (0, \_TZ.MEB1)
+	Store (0, \_TZ.MEB2)
+
 	/* Not implemented.  */
 	Return(Package(){0,0})
 }
diff --git a/src/mainboard/lenovo/t530/dsdt.asl b/src/mainboard/lenovo/t530/dsdt.asl
index 0e7a965..c73f795 100644
--- a/src/mainboard/lenovo/t530/dsdt.asl
+++ b/src/mainboard/lenovo/t530/dsdt.asl
@@ -24,6 +24,7 @@
 #define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.LCD0.DECB
 #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
 #define RP03_IS_EXPRESSCARD 1
+#define EC_LENOVO_H8_ME_WORKAROUND 1
 #define HAVE_LCD_SCREEN 1
 
 DefinitionBlock(



More information about the coreboot-gerrit mailing list