[coreboot-gerrit] New patch to review for coreboot: c0d70a9 exynos5250: Fix PMU register address map

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Fri Sep 12 20:11:23 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6892

-gerrit

commit c0d70a9516f751c20ba1200e4a6e38c1298beabb
Author: Julius Werner <jwerner at chromium.org>
Date:   Mon Dec 9 15:42:53 2013 -0800

    exynos5250: Fix PMU register address map
    
    Patch 12b121f3fef61d introduced an off-by-one error in the offsets of the
    PMU register struct, which put both the newly added register and the
    PSHOLD that comes after it in the wrong place. This patch corrects the
    offsets (5420 had already been correct).
    
    Change-Id: I1d9d31a6a73ee91890824e94fbd247d5feb4f6ae
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/179411
    Reviewed-by: Gabe Black <gabeblack at chromium.org>
    Reviewed-by: Hung-Te Lin <hungte at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit 5fdc74bc18bcb1066a0ce3ba94829af1b175173b)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 src/soc/samsung/exynos5250/power.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/samsung/exynos5250/power.h b/src/soc/samsung/exynos5250/power.h
index 5ea73c7..aa93893 100644
--- a/src/soc/samsung/exynos5250/power.h
+++ b/src/soc/samsung/exynos5250/power.h
@@ -58,8 +58,8 @@ struct exynos5_power {
 	uint32_t	inform0;		/* 0x0800 */
 	uint32_t	inform1;		/* 0x0804 */
 	uint8_t		reserved6[0x1f8];
-	uint32_t	pmu_debug;		/* 0x0A00*/
-	uint8_t         reserved7[0x2728];
+	uint32_t	pmu_debug;		/* 0x0a00 */
+	uint8_t         reserved7[0x2724];
         uint32_t        padret_uart_opt;        /* 0x3128 */
         uint8_t         reserved8[0x1e0];
 	uint32_t	ps_hold_ctrl;		/* 0x330c */



More information about the coreboot-gerrit mailing list