[coreboot-gerrit] Patch merged into coreboot/master: fa73875 libpayload: Add wrappers for malloc which check its return value.

gerrit at coreboot.org gerrit at coreboot.org
Mon Sep 15 17:40:22 CEST 2014


the following patch was just integrated into master:
commit fa73875f3c016fb544c4daa8a7053905dbd1a33e
Author: Gabe Black <gabeblack at google.com>
Date:   Sat Nov 23 00:54:40 2013 -0800

    libpayload: Add wrappers for malloc which check its return value.
    
    The xmalloc wrapper checks whether the malloc succeeded, and if not stops
    execution and prints a message. xmalloc always returns a valid pointer. The
    xzalloc wrapper does the same thing, but also zeroes the memory before
    returning it.
    
    Old-Change-Id: I00e7de04a5c368ab3603530b98bd3e3596e10632
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://chromium-review.googlesource.com/178001
    Reviewed-by: Julius Werner <jwerner at chromium.org>
    Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit 4029796d4f66601e33ae3038dbfc3299f56baf89)
    
    libpayload: malloc: Fix xmalloc() for zero byte allocations
    
    The C standard considers it legal to return a NULL pointer for zero
    length memory allocations, and our malloc implementation does in fact
    make use of that. xmalloc() and xzmalloc() should therefore not consider
    this case a failure.
    
    Also fixed a minor formatting issue.
    
    Old-Change-Id: Ib9b75df9458ce2ba75fd0bc0af9814a3323298eb
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/178725
    Reviewed-by: Mike Frysinger <vapier at chromium.org>
    Reviewed-by: David Hendricks <dhendrix at chromium.org>
    (cherry picked from commit 3033437e9d89c6072464860ea50ea27dcb76fe54)
    
    Squashed 2 libpayload malloc related commits.
    
    Change-Id: I682ef5f4aad58c93ae2be40e2edc1fd29e5d0438
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
    Reviewed-on: http://review.coreboot.org/6890
    Tested-by: build bot (Jenkins)
    Reviewed-by: David Hendricks <dhendrix at chromium.org>


See http://review.coreboot.org/6890 for details.

-gerrit



More information about the coreboot-gerrit mailing list