[coreboot-gerrit] New patch to review for coreboot: 1cb3ef6 Peppy/Falco: always use native graphics

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Tue Sep 16 00:30:25 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6912

-gerrit

commit 1cb3ef6d7bd56a86475a8b0f748bf153f961ab0b
Author: Ronald G. Minnich <rminnich at google.com>
Date:   Mon Dec 30 09:09:31 2013 -0800

    Peppy/Falco: always use native graphics
    
    The products having shipped, and living in their own branch,
    we might as well enable native graphics since:
    1. it works
    2. it removes a blob and the only good blob is a dead blob
    3. it's faster
    4. when we have problems, we can diagnose them more easily
    5. when we get to newer kernels the boot time will magically get faster
    as the driver realizes graphics is running. Where else do you get a 3-4 second
    speedup for free?
    
    Change-Id: Iad937320e7f46b1de7ab00dace04115a7f182ed1
    Signed-off-by: Ronald G. Minnich <rminnich at google.com>
    Reviewed-on: https://chromium-review.googlesource.com/181225
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Commit-Queue: Ronald Minnich <rminnich at chromium.org>
    Tested-by: Ronald Minnich <rminnich at chromium.org>
    (cherry picked from commit 7b567d87a9fcf6736e90e730bd052e4465d57bdf)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 src/mainboard/google/falco/Kconfig | 1 +
 src/mainboard/google/falco/gma.c   | 1 -
 src/mainboard/google/peppy/Kconfig | 1 +
 src/mainboard/google/peppy/gma.c   | 1 -
 4 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/falco/Kconfig b/src/mainboard/google/falco/Kconfig
index 3323fc2..ba39c7d 100644
--- a/src/mainboard/google/falco/Kconfig
+++ b/src/mainboard/google/falco/Kconfig
@@ -19,6 +19,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select EXTERNAL_MRC_BLOB
 	select MONOTONIC_TIMER_MSR
 	select MAINBOARD_HAS_NATIVE_VGA_INIT
+	select MAINBOARD_DO_NATIVE_VGA_INIT
 	select INTEL_INT15
 
 config VBOOT_RAMSTAGE_INDEX
diff --git a/src/mainboard/google/falco/gma.c b/src/mainboard/google/falco/gma.c
index 38ea162..6e3afdb 100644
--- a/src/mainboard/google/falco/gma.c
+++ b/src/mainboard/google/falco/gma.c
@@ -31,7 +31,6 @@
 #include <arch/io.h>
 #include <arch/interrupt.h>
 #include <boot/coreboot_tables.h>
-#include "hda_verb.h"
 #include <smbios.h>
 #include <device/pci.h>
 #include <ec/google/chromeec/ec.h>
diff --git a/src/mainboard/google/peppy/Kconfig b/src/mainboard/google/peppy/Kconfig
index 2343b8d..f991903 100644
--- a/src/mainboard/google/peppy/Kconfig
+++ b/src/mainboard/google/peppy/Kconfig
@@ -19,6 +19,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select EXTERNAL_MRC_BLOB
 	select MONOTONIC_TIMER_MSR
 	select MAINBOARD_HAS_NATIVE_VGA_INIT
+	select MAINBOARD_DO_NATIVE_VGA_INIT
 	select INTEL_DP
 	select INTEL_DDI
 	select INTEL_INT15
diff --git a/src/mainboard/google/peppy/gma.c b/src/mainboard/google/peppy/gma.c
index 972dd76..953dad9 100644
--- a/src/mainboard/google/peppy/gma.c
+++ b/src/mainboard/google/peppy/gma.c
@@ -31,7 +31,6 @@
 #include <arch/io.h>
 #include <arch/interrupt.h>
 #include <boot/coreboot_tables.h>
-#include "hda_verb.h"
 #include <smbios.h>
 #include <device/pci.h>
 #include <ec/google/chromeec/ec.h>



More information about the coreboot-gerrit mailing list