[coreboot-gerrit] Patch set updated for coreboot: b0c7e65 google/link, intel/wtm2: Do not include non-existent "hda.h" in i915.c

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sun Sep 21 11:56:27 CEST 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6945

-gerrit

commit b0c7e65a3143ac786d8105a99373cbb95450ab5b
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Sep 21 11:28:39 2014 +0200

    google/link, intel/wtm2: Do not include non-existent "hda.h" in i915.c
    
    Commit 75c83870 (azalia: Shrink boilerplate) [1] removed the header
    file `hda_verb.h`. This header is still included in the mainboard’s
    `i915.c`, causing the following build error, when native graphics
    initialization is enabled.
    
            CC         mainboard/intel/wtm2/i915.ramstage.o
        src/mainboard/intel/wtm2/i915.c:34:22: fatal error: hda_verb.h: No such file or directory
    
    This was not caught, as native graphics initialization is not enabled
    for the build tests.
    
    It turns out that the array `mainboard_cim_verb_data` is not used in
    `src/mainboard/intel/wtm2/hda_verb.h`, so fix the problem by removing
    the inclusion.
    
    [1] http://review.coreboot.org/6840
    
    Change-Id: Ic902581c6809a1069e169cc874678146a24d75f3
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/google/link/i915.c | 1 -
 src/mainboard/intel/wtm2/i915.c  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/src/mainboard/google/link/i915.c b/src/mainboard/google/link/i915.c
index 383c891..a9028dd 100644
--- a/src/mainboard/google/link/i915.c
+++ b/src/mainboard/google/link/i915.c
@@ -31,7 +31,6 @@
 #include <arch/io.h>
 #include <arch/interrupt.h>
 #include <boot/coreboot_tables.h>
-#include "hda_verb.h"
 #include "onboard.h"
 #include "ec.h"
 #include <southbridge/intel/bd82x6x/pch.h>
diff --git a/src/mainboard/intel/wtm2/i915.c b/src/mainboard/intel/wtm2/i915.c
index 64fa6b1..f542a13 100644
--- a/src/mainboard/intel/wtm2/i915.c
+++ b/src/mainboard/intel/wtm2/i915.c
@@ -31,7 +31,6 @@
 #include <arch/io.h>
 #include <arch/interrupt.h>
 #include <boot/coreboot_tables.h>
-#include "hda_verb.h"
 #include <smbios.h>
 #include <device/pci.h>
 #include <ec/google/chromeec/ec.h>



More information about the coreboot-gerrit mailing list