[coreboot-gerrit] New patch to review for coreboot: 04992d7 northbridge/intel/i945/Kconfig: Select VGA

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sun Sep 21 12:37:23 CEST 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6947

-gerrit

commit 04992d72e3f1ae2e3ca9e982420cacebd78970b0
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Sep 21 12:21:36 2014 +0200

    northbridge/intel/i945/Kconfig: Select VGA
    
    Commit 0092c999 (i945: Support text mode gfx init) [1] broke building
    the Lenovo X60 with native graphics initialization by selecting
    `CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT`.
    
            CC         northbridge/intel/i945/gma.ramstage.o
        src/northbridge/intel/i945/gma.c: In function 'intel_gma_init':
        src/northbridge/intel/i945/gma.c:398:2: error: implicit declaration of function 'vga_textmode_init' [-Werror=implicit-function-declaration]
    
    Selecting the Kconfig variable VGA makes the declaration of the
    function `vga_textmode_init()` to be included by the preprocessor.
    
    [1] http://review.coreboot.org/6723
    
    Change-Id: Iecbb2898193078b8738425cea13cb7e6da508cab
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/northbridge/intel/i945/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/northbridge/intel/i945/Kconfig b/src/northbridge/intel/i945/Kconfig
index 360b2ab..a4da1a5 100644
--- a/src/northbridge/intel/i945/Kconfig
+++ b/src/northbridge/intel/i945/Kconfig
@@ -29,6 +29,7 @@ config NORTHBRIDGE_SPECIFIC_OPTIONS # dummy
 	select DYNAMIC_CBMEM
 	select HAVE_DEBUG_RAM_SETUP
 	select LAPIC_MONOTONIC_TIMER
+	select VGA
 
 config NORTHBRIDGE_INTEL_SUBTYPE_I945GC
 	def_bool n



More information about the coreboot-gerrit mailing list