[coreboot-gerrit] Patch merged into coreboot/master: 8047026 google/{falco, peppy}/gma.c: Do not include non-existent "hda.h"

gerrit at coreboot.org gerrit at coreboot.org
Mon Sep 22 21:29:19 CEST 2014


the following patch was just integrated into master:
commit 804702602c017f9aebb66f409f8ed9a5d9200a4e
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Sep 21 11:53:56 2014 +0200

    google/{falco,peppy}/gma.c: Do not include non-existent "hda.h"
    
    Commit 75c83870 (azalia: Shrink boilerplate) [1] removed the header
    file `hda_verb.h`. This header is still included in the mainboard’s
    `gma.c`, causing the following build error, when native graphics
    initialization is enabled.
    
            CC         mainboard/google/falco/gma.ramstage.o
        src/mainboard/google/falco/gma.c:34:22: fatal error: hda_verb.h: No such file or directory
    
    This was not caught, as native graphics initialization is not enabled
    for the build tests.
    
    It turns out that the array `mainboard_cim_verb_data` is not used in
    `src/mainboard/intel/wtm2/hda_verb.h`, so fix the problem by removing
    the inclusion.
    
    [1] http://review.coreboot.org/6840
    
    Change-Id: I91e4f00a3030bdef0278102df2783258389bca13
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/6946
    Tested-by: build bot (Jenkins)
    Reviewed-by: Vladimir Serbinenko <phcoder at gmail.com>
    Reviewed-by: Aaron Durbin <adurbin at google.com>


See http://review.coreboot.org/6946 for details.

-gerrit



More information about the coreboot-gerrit mailing list