[coreboot-gerrit] New patch to review for coreboot: 788bc04 rmodule: Fix rmodule.ld for 64-bit

Furquan Shaikh (furquan@google.com) gerrit at coreboot.org
Tue Sep 23 00:59:08 CEST 2014


Furquan Shaikh (furquan at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6953

-gerrit

commit 788bc04309e5914b5b24a7c47aef25bf2d53c689
Author: Furquan Shaikh <furquan at google.com>
Date:   Tue Aug 26 15:01:41 2014 -0700

    rmodule: Fix rmodule.ld for 64-bit
    
    Fix the alignment for 64-bit systems
    
    Change-Id: I7fcb1683d760b96307759b7d44d8770dd49a02e3
    Signed-off-by: Furquan Shaikh <furquan at google.com>
    Reviewed-on: https://chromium-review.googlesource.com/214326
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Tested-by: Furquan Shaikh <furquan at chromium.org>
    Commit-Queue: Aaron Durbin <adurbin at chromium.org>
---
 src/lib/rmodule.ld | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/lib/rmodule.ld b/src/lib/rmodule.ld
index 84323ce..06458de 100644
--- a/src/lib/rmodule.ld
+++ b/src/lib/rmodule.ld
@@ -30,26 +30,30 @@ SECTIONS
 		__CTOR_LIST__ = .;
 		*(.ctors);
 		LONG(0);
+		LONG(0);
 		__CTOR_END__ = .;
 
 		/* The driver sections are to allow linking coreboot's
 		 * ramstage with the rmodule linker. Any changes made in
 		 * ramstage.ld should be made here as well. */
+		. = ALIGN(8);
 		pci_drivers = . ;
 		*(.rodata.pci_driver)
 		epci_drivers = . ;
+		. = ALIGN(8);
 		cpu_drivers = . ;
 		*(.rodata.cpu_driver)
 		ecpu_drivers = . ;
+		. = ALIGN(8);
 		_bs_init_begin = .;
 		*(.bs_init)
 		_bs_init_end = .;
 
-		. = ALIGN(4);
+		. = ALIGN(8);
 
 		*(.rodata);
 		*(.rodata.*);
-		. = ALIGN(4);
+		. = ALIGN(8);
 
 		/* The parameters section can be used to pass parameters
 		 * to a module, however there has to be an prior agreement
@@ -63,7 +67,7 @@ SECTIONS
 		_sdata = .;
 		*(.data);
 		*(.data.*);
-		. = ALIGN(4);
+		. = ALIGN(8);
 		_edata = .;
 
 		. = ALIGN(8);



More information about the coreboot-gerrit mailing list