[coreboot-gerrit] New patch to review for coreboot: a31afc9 Remove stale char[] initialization causing unaligned memory access

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Thu Sep 25 18:56:13 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6974

-gerrit

commit a31afc9747186ebcd9e4b302f53e7516e3ea1c07
Author: Marcelo Povoa <marcelogp at chromium.org>
Date:   Fri Feb 14 15:42:49 2014 -0800

    Remove stale char[] initialization causing unaligned memory access
    
    This throws an alignment fault when run in ARMv8 Foundation
    model and seems unnecessary, so remove it.
    
    Change-Id: I2e3aa54502c292958ba44ff4e2e71c27653f2e1a
    Signed-off-by: Marcelo Povoa <marcelogp at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/186744
    Reviewed-by: David Hendricks <dhendrix at chromium.org>
    (cherry picked from commit 57510d553c56ca5dfb4765836ddb901744e29e20)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 src/device/device_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/device/device_util.c b/src/device/device_util.c
index 4526c48..d5466cb 100644
--- a/src/device/device_util.c
+++ b/src/device/device_util.c
@@ -796,7 +796,7 @@ void print_resource_tree(struct device *root, int debug_level, const char *msg)
 
 void show_devs_tree(struct device *dev, int debug_level, int depth, int linknum)
 {
-	char depth_str[20] = "";
+	char depth_str[20];
 	int i;
 	struct device *sibling;
 	struct bus *link;



More information about the coreboot-gerrit mailing list