[coreboot-gerrit] Patch merged into coreboot/master: 1f8d246 arm: Fix up new cache flush algorithm and replace dcache_*_all() with it

gerrit at coreboot.org gerrit at coreboot.org
Mon Sep 29 17:26:55 CEST 2014


the following patch was just integrated into master:
commit 1f8d246d2f69e9f130a736204faa77685a0cc937
Author: Julius Werner <jwerner at chromium.org>
Date:   Wed Jan 15 14:13:25 2014 -0800

    arm: Fix up new cache flush algorithm and replace dcache_*_all() with it
    
    This patch fixes the remaining few bugs in our shiny new cache iteration
    by set/way/level algorithm to actually make it work: It makes it start
    from cache level 0 (previously it would always start at LoC and be
    "done" instantly), fixes up the two shifts that isolate the set bits at
    the end (which didn't seem to account for the fact that the first shift
    affects the second), and throws an S bit on that last shift so that it
    actually affects the conditionals after it.
    
    In addition, also moves the next_level block to the top so that we can
    share (and thus eliminate) some code at initialization, and turns the
    whole thing into a thrice-instantiated macro to create functions that
    fit our existing interface.
    
    Change-Id: I1338a589cbb37d74ea6e7a3d4f67ff827e24edbe
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/183879
    Reviewed-by: Stefan Reinauer <reinauer at google.com>
    Reviewed-by: David Hendricks <dhendrix at chromium.org>
    (cherry picked from commit 6d94f8330191c316fe093ddb5288329453da8a4b)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
    Reviewed-on: http://review.coreboot.org/6932
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>


See http://review.coreboot.org/6932 for details.

-gerrit



More information about the coreboot-gerrit mailing list