[coreboot-gerrit] New patch to review for coreboot: f29969a southbridge/amd/pi: Add initialization of 8254 and 8259
Dave Frodin (dave.frodin@se-eng.com)
gerrit at coreboot.org
Wed Apr 1 00:06:55 CEST 2015
Dave Frodin (dave.frodin at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9182
-gerrit
commit f29969aa3b14f7de1cd3ff104037b751e756bfe7
Author: Dave Frodin <dave.frodin at se-eng.com>
Date: Tue Mar 31 16:04:47 2015 -0600
southbridge/amd/pi: Add initialization of 8254 and 8259
Change-Id: I73b375754ee4a9bf15981f2cd31056d7e04db23e
Signed-off-by: Dave Frodin <dave.frodin at se-eng.com>
---
src/mainboard/amd/lamar/romstage.c | 10 ----------
src/southbridge/amd/pi/hudson/lpc.c | 8 ++++++++
2 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/src/mainboard/amd/lamar/romstage.c b/src/mainboard/amd/lamar/romstage.c
index 288d10f..776da83 100644
--- a/src/mainboard/amd/lamar/romstage.c
+++ b/src/mainboard/amd/lamar/romstage.c
@@ -36,8 +36,6 @@
#include <cpu/x86/lapic.h>
#include <southbridge/amd/pi/hudson/hudson.h>
#include <cpu/amd/pi/s3_resume.h>
-#include "src/drivers/pc80/i8254.c"
-#include "src/drivers/pc80/i8259.c"
#include "cbmem.h"
#include "superio/fintek/f81216h/f81216h.h"
@@ -115,14 +113,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
prepare_for_resume();
}
- /* Initialize i8259 pic */
- post_code(0x41);
- setup_i8259 ();
-
- /* Initialize i8254 timers */
- post_code(0x42);
- setup_i8254 ();
-
post_code(0x50);
copy_and_run();
diff --git a/src/southbridge/amd/pi/hudson/lpc.c b/src/southbridge/amd/pi/hudson/lpc.c
index 7e2ec00..555e255 100644
--- a/src/southbridge/amd/pi/hudson/lpc.c
+++ b/src/southbridge/amd/pi/hudson/lpc.c
@@ -30,6 +30,8 @@
#include <arch/io.h>
#include <arch/acpi.h>
#include <arch/ioapic.h>
+#include <pc80/i8254.h>
+#include <pc80/i8259.h>
#include "hudson.h"
static void lpc_init(device_t dev)
@@ -79,6 +81,12 @@ static void lpc_init(device_t dev)
* 1 tells cmos_init to always initialize the CMOS.
*/
cmos_init(0);
+
+ /* Initialize i8259 pic */
+ setup_i8259 ();
+
+ /* Initialize i8254 timers */
+ setup_i8254 ();
}
static void hudson_lpc_read_resources(device_t dev)
More information about the coreboot-gerrit
mailing list