[coreboot-gerrit] New patch to review for coreboot: 3a7162a coreboot: force 4-byte alignment for init structure with GCC 4.9
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Wed Apr 1 23:37:30 CEST 2015
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9227
-gerrit
commit 3a7162a60e609755afbe23ff4389227b54a2cbd2
Author: Ryan Lin <ryan.lin at intel.com>
Date: Mon Oct 13 14:22:38 2014 -0700
coreboot: force 4-byte alignment for init structure with GCC 4.9
Force 4-byte alignment for .bs_init section to ensure that no padding
data is added to init structures.
BUG=chromium:416651
BRANCH=none
TEST=build firmware with GCC 4.9 and test on Auron and Rambi.
Change-Id: Ib81ffa5d71256007106f6e5c773da377f151f174
Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
Original-Commit-Id: c3fc03bc2e3c7745f261f3b3fbffef6d49617f9c
Original-Change-Id: I3f94cd419b5951fdc6e5749576c4df2cc44f8a24
Original-Signed-off-by: Ryan Lin <ryan.lin at intel.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/223116
Original-Reviewed-by: Shawn Nematbakhsh <shawnn at chromium.org>
Original-Reviewed-by: Kenji Chen <kenji.chen at intel.com>
Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
src/include/bootstate.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/include/bootstate.h b/src/include/bootstate.h
index 8b5e4be..490acd8 100644
--- a/src/include/bootstate.h
+++ b/src/include/bootstate.h
@@ -185,7 +185,8 @@ struct boot_state_init_entry {
struct boot_state_callback bscb;
};
-#define BOOT_STATE_INIT_ATTR __attribute__ ((used,section (".bs_init")))
+#define BOOT_STATE_INIT_ATTR \
+ __attribute__ ((used, aligned(4), section(".bs_init")))
#define BOOT_STATE_INIT_ENTRY(state_, when_, func_, arg_) \
static struct boot_state_init_entry func_ ##_## state_ ##_## when_ = \
More information about the coreboot-gerrit
mailing list