[coreboot-gerrit] Patch set updated for coreboot: 6bca87c nvramtool: fix getopt handling with unsigned char
Stefan Tauner (stefan.tauner@gmx.at)
gerrit at coreboot.org
Mon Apr 6 20:52:08 CEST 2015
Stefan Tauner (stefan.tauner at gmx.at) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9307
-gerrit
commit 6bca87c70eb52be415a79dc338420d161b9159b4
Author: Stefan Tauner <stefan.tauner at gmx.at>
Date: Sun Apr 5 23:13:53 2015 +0200
nvramtool: fix getopt handling with unsigned char
make failed while executing "OPTION option_table.h" by printing
nvramtool's usage message when crosscompiling coreboot on the BBB.
The reason is the usage of char for the return value of getopt instead
of int and comparing it to -1 later... although char might be unsigned
as it is usually on ARM.
Change-Id: Ib20fd5ef174d484bbb35f80150b8f898d95d0fe4
Signed-off-by: Stefan Tauner <stefan.tauner at gmx.at>
---
util/nvramtool/cli/opts.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/util/nvramtool/cli/opts.c b/util/nvramtool/cli/opts.c
index 8e920e8..a128c0b 100644
--- a/util/nvramtool/cli/opts.c
+++ b/util/nvramtool/cli/opts.c
@@ -51,8 +51,7 @@ static const char getopt_string[] = "-ab:B:c::C:dD:e:hH:iL:l::np:r:tvw:xX:y:Y";
void parse_nvramtool_args(int argc, char *argv[])
{
nvramtool_op_modifier_info_t *mod_info;
- int i, op_found;
- char c;
+ int i, op_found, c;
for (i = 0, mod_info = nvramtool_op_modifiers;
i < NVRAMTOOL_NUM_OP_MODIFIERS; i++, mod_info++) {
More information about the coreboot-gerrit
mailing list