[coreboot-gerrit] New patch to review for coreboot: 2923726 vboot: remove vboot_handoff.h from chromeos.h
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Fri Apr 10 22:02:58 CEST 2015
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9566
-gerrit
commit 29237268befbe7ddb958e665c26108657a0e3a80
Author: Daisuke Nojiri <dnojiri at chromium.org>
Date: Tue Feb 3 14:44:55 2015 -0800
vboot: remove vboot_handoff.h from chromeos.h
chromeos.h includes vboot_handoff.h, which includes vboot_api.h. since
vboot_api.h is not available to non-chromeos projects, build fails for
some boards (e.g. glados).
this change removes (unnecessary) inclusion of vboot_handoff.h in chromeos.h
and fixes other files which rely on indirect inclusion of vboot_handoff.h
by making it direct.
BUG=none
BRANCH=tot
TEST=built for cosmos, falco, lumpy, nyan_blaze, parrot, rambi, rush_ryu,
samus, storm, veyron_pinky
Change-Id: I465e3657c6a0944bc75a669e5e52e74d46b3ec6c
Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
Original-Commit-Id: 6ace70d721aceae9257288815ce8fd7c6c74b8f5
Original-Signed-off-by: Daisuke Nojiri <dnojiri at chromium.org>
Original-Change-Id: I12612773372e358584d12fffaf5f968a46083fab
Original-Reviewed-on: https://chromium-review.googlesource.com/245864
Original-Tested-by: Leroy P Leahy <leroy.p.leahy at intel.com>
Original-Reviewed-by: Leroy P Leahy <leroy.p.leahy at intel.com>
Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
src/vendorcode/google/chromeos/chromeos.c | 1 +
src/vendorcode/google/chromeos/vboot_common.c | 1 +
src/vendorcode/google/chromeos/vboot_context.h | 1 +
3 files changed, 3 insertions(+)
diff --git a/src/vendorcode/google/chromeos/chromeos.c b/src/vendorcode/google/chromeos/chromeos.c
index 437e128..97c7e4f 100644
--- a/src/vendorcode/google/chromeos/chromeos.c
+++ b/src/vendorcode/google/chromeos/chromeos.c
@@ -24,6 +24,7 @@
#include <cbfs.h>
#include <cbmem.h>
#include <console/console.h>
+#include "vboot_handoff.h"
static int vboot_enable_developer(void)
{
diff --git a/src/vendorcode/google/chromeos/vboot_common.c b/src/vendorcode/google/chromeos/vboot_common.c
index b2893d9..ef47fc8 100644
--- a/src/vendorcode/google/chromeos/vboot_common.c
+++ b/src/vendorcode/google/chromeos/vboot_common.c
@@ -25,6 +25,7 @@
#include <console/console.h>
#include "chromeos.h"
#include "vboot_common.h"
+#include "vboot_handoff.h"
void vboot_locate_region(const char *name, struct vboot_region *region)
{
diff --git a/src/vendorcode/google/chromeos/vboot_context.h b/src/vendorcode/google/chromeos/vboot_context.h
index 2517f63e..703d69b 100644
--- a/src/vendorcode/google/chromeos/vboot_context.h
+++ b/src/vendorcode/google/chromeos/vboot_context.h
@@ -22,6 +22,7 @@
#include <stdint.h>
#include <vboot_api.h>
#include "chromeos.h"
+#include "vboot_handoff.h"
struct cbmem_entry;
More information about the coreboot-gerrit
mailing list