[coreboot-gerrit] New patch to review for coreboot: b7be73e rk3288: meet the backlight power timing request
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Tue Apr 14 02:41:53 CEST 2015
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9658
-gerrit
commit b7be73e60ce6d66eca9d0c36f3f34c35dd8d8921
Author: huang lin <hl at rock-chips.com>
Date: Fri Jan 30 21:05:58 2015 +0800
rk3288: meet the backlight power timing request
backlight timing: LED_VCC->LED_PWM->LED_EN, we modify the
code to meet the timing.
BUG=chrome-os-partner:36201
TEST=Boot from jerry, and scope the backlight timing
BRANCH=None
Change-Id: I6bfa6af176400086e4af0112a63127c1152ca70e
Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
Original-Commit-Id: 52ac0b2944cea7dc860bfea12fe44851436bb7f7
Original-Change-Id: I6c53a822410ad706383c6d9fa2b5f0437775f710
Original-Signed-off-by: huang lin <hl at rock-chips.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/244639
Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
src/mainboard/google/veyron_jerry/mainboard.c | 6 +++---
src/mainboard/google/veyron_mighty/mainboard.c | 6 +++---
src/mainboard/google/veyron_pinky/mainboard.c | 6 +++---
src/mainboard/google/veyron_speedy/mainboard.c | 6 +++---
4 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/mainboard/google/veyron_jerry/mainboard.c b/src/mainboard/google/veyron_jerry/mainboard.c
index 0d814d5..9efcf72 100644
--- a/src/mainboard/google/veyron_jerry/mainboard.c
+++ b/src/mainboard/google/veyron_jerry/mainboard.c
@@ -153,10 +153,10 @@ void mainboard_power_on_backlight(void)
break;
default:
gpio_output(GPIO(2, B, 4), 1); /* BL_PWR_EN */
+ mdelay(20);
+ gpio_output(GPIO_BACKLIGHT, 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO(7, A, 2), 1); /* LCD_BL */
- mdelay(10);
- gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
+ gpio_output(GPIO(7, A, 2), 1); /* BL_EN */
break;
}
}
diff --git a/src/mainboard/google/veyron_mighty/mainboard.c b/src/mainboard/google/veyron_mighty/mainboard.c
index 2807b7b..4e69ec9 100644
--- a/src/mainboard/google/veyron_mighty/mainboard.c
+++ b/src/mainboard/google/veyron_mighty/mainboard.c
@@ -153,10 +153,10 @@ void mainboard_power_on_backlight(void)
break;
default:
gpio_output(GPIO(2, B, 4), 1); /* BL_PWR_EN */
+ mdelay(20);
+ gpio_output(GPIO_BACKLIGHT, 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO(7, A, 2), 1); /* LCD_BL */
- mdelay(10);
- gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
+ gpio_output(GPIO(7, A, 2), 1); /* BL_EN */
break;
}
}
diff --git a/src/mainboard/google/veyron_pinky/mainboard.c b/src/mainboard/google/veyron_pinky/mainboard.c
index fd0c60d..16367bc 100644
--- a/src/mainboard/google/veyron_pinky/mainboard.c
+++ b/src/mainboard/google/veyron_pinky/mainboard.c
@@ -199,10 +199,10 @@ void mainboard_power_on_backlight(void)
break;
default:
gpio_output(GPIO(2, B, 4), 1); /* BL_PWR_EN */
+ mdelay(20);
+ gpio_output(GPIO_BACKLIGHT, 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO(7, A, 2), 1); /* LCD_BL */
- mdelay(10);
- gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
+ gpio_output(GPIO(7, A, 2), 1); /* BL_EN */
break;
}
}
diff --git a/src/mainboard/google/veyron_speedy/mainboard.c b/src/mainboard/google/veyron_speedy/mainboard.c
index 2807b7b..4e69ec9 100644
--- a/src/mainboard/google/veyron_speedy/mainboard.c
+++ b/src/mainboard/google/veyron_speedy/mainboard.c
@@ -153,10 +153,10 @@ void mainboard_power_on_backlight(void)
break;
default:
gpio_output(GPIO(2, B, 4), 1); /* BL_PWR_EN */
+ mdelay(20);
+ gpio_output(GPIO_BACKLIGHT, 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO(7, A, 2), 1); /* LCD_BL */
- mdelay(10);
- gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
+ gpio_output(GPIO(7, A, 2), 1); /* BL_EN */
break;
}
}
More information about the coreboot-gerrit
mailing list