[coreboot-gerrit] Patch merged into coreboot/master: dbfa9d5 veyron: Turn off SD card power in romstage
gerrit at coreboot.org
gerrit at coreboot.org
Wed Apr 15 07:30:13 CEST 2015
the following patch was just integrated into master:
commit dbfa9d5e8db75490669330301bd1661571f24cfc
Author: Julius Werner <jwerner at chromium.org>
Date: Fri Dec 5 17:29:42 2014 -0800
veyron: Turn off SD card power in romstage
The only way to reliably reset an SD card in an unknown state is by
power-cycling. Since a kernel may crash and reboot at any point, SD
cards may be left in one of them fancy high-throughput modes that
depthcharge (or, in fact, a newly booting kernel without prior
knowledge) doesn't support, so we need to reset the card on every boot.
This patch adds support to turn off an RK808 regulator completely and
uses that to turn off SD card power rails in early romstage. The time
until configure_sdmmc() in ramstage turns them back on should be more
than enough to drain the power rail for an effective power-cycle.
BRANCH=None
BUG=chrome-os-partner:34289
TEST=Booted a Pinky from SD card, noticed that it works before and
after this patch.
Change-Id: Iaa5f7adaa59da69a964785c5e369ad73c6620224
Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
Original-Commit-Id: 95fba21907f1f3f686cb5a95b993736247db8f96
Original-Change-Id: I904b2d23ca35f765c000f9bee7637044f674eff9
Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/233713
Original-Reviewed-by: Alexandru Stan <amstan at chromium.org>
Original-Tested-by: Alexandru Stan <amstan at chromium.org>
Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
Reviewed-on: http://review.coreboot.org/9626
Tested-by: build bot (Jenkins)
Reviewed-by: Julius Werner <jwerner at chromium.org>
Reviewed-by: Marc Jones <marc.jones at se-eng.com>
See http://review.coreboot.org/9626 for details.
-gerrit
More information about the coreboot-gerrit
mailing list