[coreboot-gerrit] New patch to review for coreboot: bb22025 libpayload: More defensive ChipIdea initialization
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Fri Apr 17 13:16:14 CEST 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9787
-gerrit
commit bb22025725ab577a12c429448fa28dde3dd78053
Author: Patrick Georgi <pgeorgi at google.com>
Date: Tue Mar 10 12:47:36 2015 +0100
libpayload: More defensive ChipIdea initialization
Mark EP0 non-stall explicitly. Shouldn't be necessary, but
won't hurt either.
BRANCH=none
BUG=none
TEST=none
Change-Id: I7ecd16a2affe064918d93436aedfa07bd9a1cf56
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: a0fc237b33444fc30dc5b62e4f1afc3188f2cf43
Original-Change-Id: I1aa8742eebc4de733317600e35627631ebaf4724
Original-Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/258061
Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
---
payloads/libpayload/drivers/udc/chipidea.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/payloads/libpayload/drivers/udc/chipidea.c b/payloads/libpayload/drivers/udc/chipidea.c
index 87c3076..a399e8c 100644
--- a/payloads/libpayload/drivers/udc/chipidea.c
+++ b/payloads/libpayload/drivers/udc/chipidea.c
@@ -128,6 +128,9 @@ static int chipidea_hw_init(struct usbdev_ctrl *this, void *_opreg,
debug("taking controller out of reset\n");
writel(USBCMD_8MICRO | USBCMD_RUN, &p->opreg->usbcmd);
+ this->stall(this, 0, 0, 0);
+ this->stall(this, 0, 1, 0);
+
return 1;
}
More information about the coreboot-gerrit
mailing list