[coreboot-gerrit] New patch to review for coreboot: Revert "SeaBIOS: fix reproducible build by defining our own version string"

Kevin O'Connor (kevin@koconnor.net) gerrit at coreboot.org
Thu Aug 13 00:49:24 CEST 2015


Kevin O'Connor (kevin at koconnor.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11223

-gerrit

commit cb2d3a48eafd12b6443d1c44436ffb2432c8077e
Author: Kevin O'Connor <kevin at koconnor.net>
Date:   Wed Aug 12 18:38:59 2015 -0400

    Revert "SeaBIOS: fix reproducible build by defining our own version string"
    
    This reverts commit 633886719e2853744d932bd15324dd21634b0bbb.
    
    The SeaBIOS maintainer (Kevin O'Connor) has requested that default
    builds of SeaBIOS continue to use the default SeaBIOS version string.
    The commit above changed the default for coreboot builds of SeaBIOS.
    This non-standard version string contains less information and it
    makes it harder for SeaBIOS developers to respond to trouble reports.
    
    Change-Id: I65f039b06dc4ee857b200bc2b67eea503fa7f537
    Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
---
 payloads/external/SeaBIOS/Makefile.inc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/payloads/external/SeaBIOS/Makefile.inc b/payloads/external/SeaBIOS/Makefile.inc
index 7fb63d4..7390dd3 100644
--- a/payloads/external/SeaBIOS/Makefile.inc
+++ b/payloads/external/SeaBIOS/Makefile.inc
@@ -47,9 +47,6 @@ endif
 
 build: config
 	echo "    MAKE       SeaBIOS $(TAG-y)"
-	export VERSION=$$(cd seabios && \
-		git describe --tags --long --dirty 2>/dev/null || \
-		echo "unknown") ; \
 	$(MAKE) -C seabios OUT=out/
 
 clean:



More information about the coreboot-gerrit mailing list