[coreboot-gerrit] Patch merged into coreboot/master: libpayload: usb: xhci: Count new Max Scratchpad Bufs bits from XHCI 1.1

gerrit at coreboot.org gerrit at coreboot.org
Fri Aug 14 15:17:35 CEST 2015


the following patch was just integrated into master:
commit 57ddd9abc79048efc658878f021927846fef6a0a
Author: Julius Werner <jwerner at chromium.org>
Date:   Fri Aug 7 13:14:20 2015 -0700

    libpayload: usb: xhci: Count new Max Scratchpad Bufs bits from XHCI 1.1
    
    The 1.1 revision of the XHCI specification added an extra 5 bits to the
    Max Scratchpad Bufs field of HCSPARAMS2 that newer controllers make use
    of. Not honoring these bits means we're not allocating as many
    scratchpad buffers as the controller expects, which means it will
    interpret some uninitialized values from the end of the pointer array as
    scratchpad buffer pointers, which obviously doesn't end well. Let's fix
    that.
    
    BRANCH=none
    BUG=chrome-os-partner:42279
    TEST=Makes a USB-related memory corruption issue disappear.
    
    Original-Change-Id: I7c907492339262bda31cdd2b5c0b588de7df8544
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/291681
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    
    Change-Id: Iba1007bfebffe1f564f78bb875fff9ba0fe11a38
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: http://review.coreboot.org/11189
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/11189 for details.

-gerrit



More information about the coreboot-gerrit mailing list