[coreboot-gerrit] Patch merged into coreboot/master: skylake: remove ec_smi_gpio and alt_gp_smi_en

gerrit at coreboot.org gerrit at coreboot.org
Fri Aug 14 15:20:57 CEST 2015


the following patch was just integrated into master:
commit f50b25d7e2c979e2b8cddb76039afcdeb686e1c0
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Aug 7 22:57:42 2015 -0500

    skylake: remove ec_smi_gpio and alt_gp_smi_en
    
    The ec_smi_gpio and alt_gp_smi_en devicetree options are
    goign to be removed. The plan for skylake is to set the
    settings by the mainboard through either gpio pad
    configuration or through helper functions.
    
    Moreover, these values only allow *1* SMI GPIO configuration
    in that the following has to be true:
    alt_gp_smi_en = 1 << (ec_smi_gpio % 24)
    If not, then another gpio(s) from the same group has the
    SMI_EN bit set for it.
    
    Lastly, remove all the subsequent dependencies as they are
    no longer used: enable_alt_smi() and gpio_enable_group().
    
    BUG=chrome-os-partner:43778
    BRANCH=None
    TEST=None
    
    Original-Change-Id: I749a499c810d83de522a2ccce1dd9efb0ad2e20a
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/291931
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    
    Change-Id: I2e1cd6879b76923157268a1449c617ef2aada9c4
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/11204
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/11204 for details.

-gerrit



More information about the coreboot-gerrit mailing list