[coreboot-gerrit] Patch merged into coreboot/master: mainboard: Get CHROMEOS/MAINBOARD_HAS_CHROMEOS right (again)

gerrit at coreboot.org gerrit at coreboot.org
Thu Aug 20 20:51:43 CEST 2015


the following patch was just integrated into master:
commit 43213be11657669a3bd93eb81320558ef1183faf
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Thu Aug 20 12:51:48 2015 -0400

    mainboard: Get CHROMEOS/MAINBOARD_HAS_CHROMEOS right (again)
    
    CHROMEOS is a user-visible bool. It must not be 'select'ed in Kconfig.
    That's why we have MAINBOARD_HAS_CHROMEOS. This is the fifth time I
    find this being used wrong.
    Why is this confusing/so hard to get right?
    
    Change-Id: Icb4629355c63508f5a044b46842524b3d203c2da
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
    Reviewed-on: http://review.coreboot.org/11290
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/11290 for details.

-gerrit



More information about the coreboot-gerrit mailing list