[coreboot-gerrit] Patch merged into coreboot/master: libpayload: usb: dwc2: Always return 'size' transferred bytes for OUT

gerrit at coreboot.org gerrit at coreboot.org
Fri Aug 28 08:46:23 CEST 2015


the following patch was just integrated into master:
commit e8a8a00342b8791b3c29827b33139aa5722b3f61
Author: Julius Werner <jwerner at chromium.org>
Date:   Mon Aug 17 18:47:18 2015 -0700

    libpayload: usb: dwc2: Always return 'size' transferred bytes for OUT
    
    Seems like our transferred bytes calculation for OUT transfers that span
    more than one packet had been wrong, and we just got lucky that we never
    noticed it before. The HCTSIZ.xfersize register field we're reading only
    counts bytes transferred by the last packet we sent.
    
    OUT endpoints cannot have short transfers -- every transfer should
    either finish all bytes we wanted to send or end in a proper error
    condition. Therefore, in the absence of an error we can just conclude
    that all input bytes have been transferred.
    
    BRANCH=veyron
    BUG=chrome-os-partner:35525
    TEST=SMSC95xx netboot on Jerry now works.
    
    Change-Id: I57349e697c428df6b56e2f6f62e87652ef1e7a94
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Original-Commit-Id: 0abee13b6d89dec12c6fff581ece1836393c7703
    Original-Change-Id: Id0a127e6919f5786ba05218277705dda1067b8c3
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/293956
    Original-Reviewed-by: yunzhi li <lyz at rock-chips.com>
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/11404
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/11404 for details.

-gerrit



More information about the coreboot-gerrit mailing list