[coreboot-gerrit] Patch merged into coreboot/master: intel/skylake: Fix RMT disable of saved training data

gerrit at coreboot.org gerrit at coreboot.org
Sat Aug 29 09:18:56 CEST 2015


the following patch was just integrated into master:
commit 08a6fd309f9396fc7bdcbdc9608661da3a8c94a7
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed Aug 19 11:03:59 2015 -0700

    intel/skylake: Fix RMT disable of saved training data
    
    The RMT flag that was attempting to disable saved training to
    force a full memory train was happening too late.  In testing
    I was actually hitting a case where FSP was training every time
    but it was not because it was properly being told to.
    
    This moves the check of the RMT flag from devicetree to happen
    ealier, before it is actually consumed by romstage_common().
    
    BUG=chrome-os-partner:40635
    BRANCH=none
    TEST=do both power off+on and warm resets to ensure that FSP
    is doing a full memory train every time with RMT enabled.
    
    Change-Id: Icf36e7b1ae20e08f6bc24bf832498d69b37dee92
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Original-Commit-Id: f3fa3846d51dec65f22f018acc8fb8c4d18688a7
    Original-Change-Id: I2128b4a24bb8b2c8ddcb792c09b6fb0284d1fda4
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/294177
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/11417
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See http://review.coreboot.org/11417 for details.

-gerrit



More information about the coreboot-gerrit mailing list