[coreboot-gerrit] New patch to review for coreboot: toolchain.inc: Test for valid toolchain when ANY_TOOLCHAIN is used
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Mon Dec 7 22:37:42 CET 2015
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12681
-gerrit
commit ad933a86d53e9c2f7df36f6a0daec8cf8193f7ce
Author: Martin Roth <martinroth at google.com>
Date: Mon Dec 7 14:33:44 2015 -0700
toolchain.inc: Test for valid toolchain when ANY_TOOLCHAIN is used
Even when ANY_TOOLCHAIN is selected, a valid compiler for the requested
architecture is needed.
Change-Id: If1a0a1ca6b726e8e58d29c69de93546510582548
Signed-off-by: Martin Roth <martinroth at google.com>
---
toolchain.inc | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/toolchain.inc b/toolchain.inc
index d512d89..3b9096c 100644
--- a/toolchain.inc
+++ b/toolchain.inc
@@ -162,6 +162,14 @@ $(foreach arch,$(sort $(foreach stage,$(COREBOOT_STANDARD_STAGES),$(ARCH-$(stage
#TODO: Figure out if iasl is even needed for the build.
$(if $(shell if [ -n "$(IASL)" ]; then $(IASL) -v 2>&1 | grep -q "$(shell util/crossgcc/buildgcc -s iasl)" || echo not-coreboot; else echo not-coreboot; fi), \
$(eval COMPILERFAIL:=1)$(eval IASLFAIL:=1)$(warning The coreboot toolchain version of iasl '$(shell util/crossgcc/buildgcc -s iasl)' was not found))
+else #$(CONFIG_ANY_TOOLCHAIN)
+$(foreach arch,$(sort $(foreach stage,$(COREBOOT_STANDARD_STAGES),$(ARCH-$(stage)-y))), \
+ $(if $(CC_$(arch)),, $(eval COMPILERFAIL:=1)$(warning No compiler found for '$(arch)' architecture. \
+Install one or use the coreboot toolchain?)) )
+#if iasl isn't present, fail
+#TODO: Figure out if iasl is even needed for the build.
+$(if $(IASL),, $(eval COMPILERFAIL:=1)$(eval IASLFAIL:=1)$(warning iasl not found. \
+Please install it or use the coreboot toolchain.))
endif
ifeq ($(COMPILERFAIL),1)
ifneq ($(XGCCPATH),)
More information about the coreboot-gerrit
mailing list