[coreboot-gerrit] New patch to review for coreboot: board_status.sh: Clean up output, show what the script is doing
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Thu Dec 17 20:49:48 CET 2015
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12759
-gerrit
commit a93415d048963405f0bdd246f4d71ab1d6fadc87
Author: Martin Roth <martinroth at google.com>
Date: Thu Dec 17 12:38:45 2015 -0700
board_status.sh: Clean up output, show what the script is doing
- Print what the script is doing so when it asks for the ssh password
several times in a row, it's obvious that it's actually doing different
things, not that the password failed.
- Don't print the output from cbfstool - it's not useful.
Change-Id: I785283475e14f242117682800c26db6b4f9f1e2c
Signed-off-by: Martin Roth <martinroth at google.com>
---
util/board_status/board_status.sh | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index fce45fb..578e40a 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -225,7 +225,8 @@ if test ! -x build/cbfstool; then
make -C util/cbfstool/ && cp util/cbfstool/cbfstool build/cbfstool
fi
test_cmd $LOCAL "$cbfstool_cmd"
-$cbfstool_cmd build/coreboot.rom extract -n config -f ${tmpdir}/config.txt
+echo "Extracting config.txt from build/coreboot.rom"
+$cbfstool_cmd build/coreboot.rom extract -n config -f "${tmpdir}/config.txt" >/dev/null 2>&1
mv ${tmpdir}/config.txt ${tmpdir}/config.short.txt
cp ${tmpdir}/config.short.txt ${tmpcfg}
yes "" | make DOTCONFIG=${tmpcfg} oldconfig 2>/dev/null >/dev/null
@@ -272,13 +273,17 @@ printf "Upstream URL: %s\n" $($getrevision -U)>> ${tmpdir}/${results}/revision.t
printf "Timestamp: %s\n" "$timestamp" >> ${tmpdir}/${results}/revision.txt
if [ -z "$SERIAL_DEVICE" ]; then
+ echo "Verifying that CBMEM is available on remote device"
test_cmd $REMOTE "cbmem"
+ echo "Getting coreboot boot log"
cmd $REMOTE "cbmem -c" "${tmpdir}/${results}/coreboot_console.txt"
+ echo "Getting timestamp data"
cmd_nonfatal $REMOTE "cbmem -t" "${tmpdir}/${results}/coreboot_timestamps.txt"
else
get_serial_bootlog "$SERIAL_DEVICE" "$SERIAL_PORT_SPEED" "${tmpdir}/${results}/coreboot_console.txt"
fi
+echo "Getting remote dmesg"
cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"
#
More information about the coreboot-gerrit
mailing list