[coreboot-gerrit] Patch merged into coreboot/master: soc/intel/broadwell: Init var before use, only use when needed
gerrit at coreboot.org
gerrit at coreboot.org
Sun Dec 20 02:42:00 CET 2015
the following patch was just integrated into master:
commit 2b2ff7fa6a9af366c1a9b8e4cb6f7f566048b0d7
Author: Martin Roth <martinroth at google.com>
Date: Fri Dec 18 10:46:59 2015 -0700
soc/intel/broadwell: Init var before use, only use when needed
root_port_init_config() pcie.c wasn't initializing a variable before
passing its pointer to pch_iobp_exec(). pch_iobp_exec() wrote the
uninitialized value into a register.
In theory, the register would only be used if data was being written,
and pch_iobp_exec() was being used to read the data, not write it, so
this change shouldn't have any practical effect.
Fixes coverity error:
CID 1293134 (#1 of 1): Uninitialized scalar variable (UNINIT)
Change-Id: I5d17863d904c6b1ceb30d72b94cd7a40c8fbb437
Signed-off-by: Martin Roth <martinroth at google.com>
Reviewed-on: https://review.coreboot.org/12778
Tested-by: build bot (Jenkins)
Reviewed-by: Duncan Laurie <dlaurie at google.com>
See https://review.coreboot.org/12778 for details.
-gerrit
More information about the coreboot-gerrit
mailing list