[coreboot-gerrit] Patch set updated for coreboot: c85a0ba northbridge/amd/pi: Remove superfluous logic operand
Dave Frodin (dave.frodin@se-eng.com)
gerrit at coreboot.org
Wed Feb 4 00:37:17 CET 2015
Dave Frodin (dave.frodin at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8289
-gerrit
commit c85a0ba5b6628f57d92df0d9f825d820ef05cece
Author: Dave Frodin <dave.frodin at se-eng.com>
Date: Fri Jan 23 07:26:14 2015 -0700
northbridge/amd/pi: Remove superfluous logic operand
Commit 2e0cf14 corrected this for pi/00730F01/northbridge.c.
This commit fixes it for pi/00630F01/northbridge.c.
Found-by: Clang
Change-Id: I4eb93a07aacf6ffc5a159222117e7c934d85859e
Signed-off-by: Dave Frodin <dave.frodin at se-eng.com>
---
src/northbridge/amd/pi/00630F01/northbridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/northbridge/amd/pi/00630F01/northbridge.c b/src/northbridge/amd/pi/00630F01/northbridge.c
index 53ba694..7221858 100644
--- a/src/northbridge/amd/pi/00630F01/northbridge.c
+++ b/src/northbridge/amd/pi/00630F01/northbridge.c
@@ -1059,7 +1059,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
printk(BIOS_SPEW, "KaveriPI Debug: Grabbing the AMD Topology Information.\n");
AmdGetValue(AMD_GLOBAL_USER_OPTIONS, (VOID**)&options, sizeof(options));
AmdGetValue(AMD_GLOBAL_NUM_MODULES, &modules_ptr, sizeof(modules));
- modules = (*(u32*)modules_ptr) && ((1ull << (sizeof(modules) * 8)) - 1);
+ modules = *(u32*)modules_ptr;
ASSERT(modules > 0);
ASSERT(options);
ioapic_count = (int)options->CfgPlatNumIoApics;
More information about the coreboot-gerrit
mailing list