[coreboot-gerrit] New patch to review for coreboot: 0864e83 drivers/i2c/w83793: Remove incorrect zeroing of PWM values

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Mon Feb 23 08:21:32 CET 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8520

-gerrit

commit 0864e83413feb5bec2ccb01f11f3cc845843f8b8
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Mon Feb 23 01:19:30 2015 -0600

    drivers/i2c/w83793: Remove incorrect zeroing of PWM values
    
    Fan 2 and Fan 3 were inexplicably set to zero after device
    setup.
    
    Change-Id: I37945745dbfaf33eb28808d85cdf75dca401e44b
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/drivers/i2c/w83793/w83793.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/drivers/i2c/w83793/w83793.c b/src/drivers/i2c/w83793/w83793.c
index 4b947d7..5b17867 100644
--- a/src/drivers/i2c/w83793/w83793.c
+++ b/src/drivers/i2c/w83793/w83793.c
@@ -211,10 +211,6 @@ static void w83793_init(struct device *dev)
 
 	smbus_write_byte(dev, 0x00, 0x00);
 
-	/* Fan output style */
-	smbus_write_byte(dev, 0xb4, 0x00);
-	smbus_write_byte(dev, 0xb5, 0x00);
-
 	/* start monitoring operation */
 	smbus_write_byte(dev, 0x40, 0x09);
 



More information about the coreboot-gerrit mailing list