[coreboot-gerrit] Patch set updated for coreboot: 133e729 AMD Fam10h: sanity check some CPU data

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8508

-gerrit

commit 133e729d296ef7516e3c607f3e26d0d302ba1896
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sun Feb 22 16:27:56 2015 +0100

    AMD Fam10h: sanity check some CPU data
    
    If a certain register returns crap values, we
    determine core_power using an uninitialized variable.
    That doesn't sound healthy.
    
    Change-Id: I1e890b78bfcc3bf0255a3d4f6561a783134b1719
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Found-by: Coverity Scan
---
 src/cpu/amd/model_10xxx/powernow_acpi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/cpu/amd/model_10xxx/powernow_acpi.c b/src/cpu/amd/model_10xxx/powernow_acpi.c
index 0b3681c..4888578 100644
--- a/src/cpu/amd/model_10xxx/powernow_acpi.c
+++ b/src/cpu/amd/model_10xxx/powernow_acpi.c
@@ -226,6 +226,9 @@ static void pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP)
 			case 0x3:
 				expanded_cpuidv = 1000;
 				break;
+			default:
+				printk(BIOS_ERR, "got invalid cpuidv\n");
+				return;
 		}
 		core_power = (core_voltage * cpuidd) / (expanded_cpuidv * 10);