[coreboot-gerrit] New patch to review for coreboot: 7d85121 AMD fam10: Refactor calls for HT configuration
Kyösti Mälkki (kyosti.malkki@gmail.com)
gerrit at coreboot.org
Sat Feb 28 15:22:35 CET 2015
Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8558
-gerrit
commit 7d8512135555b9ec82fd890b68158e7db305ae6f
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date: Sat Feb 21 11:19:01 2015 +0200
AMD fam10: Refactor calls for HT configuration
Change-Id: Ic8fbafdfadbc4ef0896d93e61c8a54ce69297e07
Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
src/northbridge/amd/amdfam10/ht_config.c | 71 +++++++++++++++++-------------
src/northbridge/amd/amdfam10/ht_config.h | 15 +++----
src/northbridge/amd/amdfam10/northbridge.c | 39 +++++++---------
3 files changed, 61 insertions(+), 64 deletions(-)
diff --git a/src/northbridge/amd/amdfam10/ht_config.c b/src/northbridge/amd/amdfam10/ht_config.c
index efb3148..57b2d0a 100644
--- a/src/northbridge/amd/amdfam10/ht_config.c
+++ b/src/northbridge/amd/amdfam10/ht_config.c
@@ -47,54 +47,51 @@ struct dram_base_mask_t get_dram_base_mask(u32 nodeid)
return d;
}
-
-void set_config_map_reg(u32 nodeid, u32 linkn, u32 ht_c_index,
- u32 busn_min, u32 busn_max, u32 segbit,
- u32 nodes)
+void set_config_map_reg(struct bus *link)
{
u32 tempreg;
u32 i;
+ u32 ht_c_index = get_ht_c_index(link);
+ u32 linkn = link->link_num & 0x0f;
+ u32 busn_min = (link->secondary >> sysconf.segbit) & 0xff;
+ u32 busn_max = (link->subordinate >> sysconf.segbit) & 0xff;
+ u32 nodeid = amdfam10_nodeid(link->dev);
- busn_min>>=segbit;
- busn_max>>=segbit;
+ tempreg = ((nodeid & 0x30) << (12-4)) | ((nodeid & 0xf) << 4) | 3;
+ tempreg |= (busn_max << 24)|(busn_min << 16)|(linkn << 8);
- tempreg = 3 | ((nodeid&0xf)<<4) | ((nodeid & 0x30)<<(12-4))|(linkn<<8)|((busn_min & 0xff)<<16)|((busn_max&0xff)<<24);
- for (i=0; i<nodes; i++) {
+ for (i=0; i < sysconf.nodes; i++) {
device_t dev = __f1_dev[i];
pci_write_config32(dev, 0xe0 + ht_c_index * 4, tempreg);
}
}
-void clear_config_map_reg(u32 nodeid, u32 linkn, u32 ht_c_index,
- u32 busn_min, u32 busn_max, u32 nodes)
+void clear_config_map_reg(struct bus *link)
{
u32 i;
+ u32 ht_c_index = get_ht_c_index(link);
- for (i=0; i<nodes; i++) {
+ for (i=0; i < sysconf.nodes; i++) {
device_t dev = __f1_dev[i];
pci_write_config32(dev, 0xe0 + ht_c_index * 4, 0);
}
}
-u32 get_ht_c_index(u32 nodeid, u32 linkn, sys_info_conf_t *sysinfo)
+static u32 ht_c_key(struct bus *link)
{
- u32 tempreg;
- u32 ht_c_index = 0;
+ u32 nodeid = amdfam10_nodeid(link->dev);
+ u32 linkn = link->link_num & 0x0f;
+ u32 val = (linkn << 8) | ((nodeid & 0x3f) << 2) | 3;
+ return val;
+}
-#if 0
- tempreg = 3 | ((nodeid & 0xf) <<4) | ((nodeid & 0x30)<<(12-4)) | (linkn<<8);
+static u32 get_ht_c_index_by_key(u32 key, sys_info_conf_t *sysinfo)
+{
+ u32 ht_c_index = 0;
- for (ht_c_index=0;ht_c_index<4; ht_c_index++) {
- reg = pci_read_config32(PCI_DEV(CONFIG_CBB, CONFIG_CDB, 1), 0xe0 + ht_c_index * 4);
- if (((reg & 0xffff) == 0x0000)) { /*found free*/
- break;
- }
- }
-#endif
- tempreg = 3 | ((nodeid & 0x3f)<<2) | (linkn<<8);
for (ht_c_index=0; ht_c_index<32; ht_c_index++) {
- if ((sysinfo->ht_c_conf_bus[ht_c_index] & 0xfff) == tempreg) {
+ if ((sysinfo->ht_c_conf_bus[ht_c_index] & 0xfff) == key) {
return ht_c_index;
}
}
@@ -108,14 +105,26 @@ u32 get_ht_c_index(u32 nodeid, u32 linkn, sys_info_conf_t *sysinfo)
return -1;
}
-void store_ht_c_conf_bus(u32 nodeid, u32 linkn, u32 ht_c_index,
- u32 busn_min, u32 busn_max,
- sys_info_conf_t *sysinfo)
+u32 get_ht_c_index(struct bus *link)
{
- u32 val;
- val = 3 | ((nodeid & 0x3f)<<2) | (linkn<<8);
- sysinfo->ht_c_conf_bus[ht_c_index] = val | ((busn_min & 0xff) <<12) | (busn_max<<20); // same node need segn are same
+ u32 val = ht_c_key(link);
+ return get_ht_c_index_by_key(val, &sysconf);
+}
+
+void store_ht_c_conf_bus(struct bus *link)
+{
+ u32 val = ht_c_key(link);
+ u32 ht_c_index = get_ht_c_index_by_key(val, &sysconf);
+
+ u32 segn = (link->subordinate >> 8) & 0x0f;
+ u32 busn_min = link->secondary & 0xff;
+ u32 busn_max = link->subordinate & 0xff;
+
+ val |= (segn << 28) | (busn_max << 20) | (busn_min << 12);
+ sysconf.ht_c_conf_bus[ht_c_index] = val;
+ sysconf.hcdn_reg[ht_c_index] = link->hcdn_reg;
+ sysconf.ht_c_num++;
}
u32 get_io_addr_index(u32 nodeid, u32 linkn)
diff --git a/src/northbridge/amd/amdfam10/ht_config.h b/src/northbridge/amd/amdfam10/ht_config.h
index 54356c1..c2d6c4c 100644
--- a/src/northbridge/amd/amdfam10/ht_config.h
+++ b/src/northbridge/amd/amdfam10/ht_config.h
@@ -20,6 +20,7 @@
typedef struct amdfam10_sysconf_t sys_info_conf_t;
/* FIXME */
+u32 amdfam10_nodeid(device_t dev);
extern device_t __f1_dev[];
struct dram_base_mask_t {
@@ -29,17 +30,11 @@ struct dram_base_mask_t {
struct dram_base_mask_t get_dram_base_mask(u32 nodeid);
-void set_config_map_reg(u32 nodeid, u32 linkn, u32 ht_c_index,
- u32 busn_min, u32 busn_max, u32 segbit,
- u32 nodes);
-void clear_config_map_reg(u32 nodeid, u32 linkn, u32 ht_c_index,
- u32 busn_min, u32 busn_max, u32 nodes);
+u32 get_ht_c_index(struct bus *link);
+void store_ht_c_conf_bus(struct bus *link);
-void store_ht_c_conf_bus(u32 nodeid, u32 linkn, u32 ht_c_index,
- u32 busn_min, u32 busn_max,
- sys_info_conf_t *sysinfo);
-
-u32 get_ht_c_index(u32 nodeid, u32 linkn, sys_info_conf_t *sysinfo);
+void set_config_map_reg(struct bus *link);
+void clear_config_map_reg(struct bus *link);
void store_conf_io_addr(u32 nodeid, u32 linkn, u32 reg, u32 index,
diff --git a/src/northbridge/amd/amdfam10/northbridge.c b/src/northbridge/amd/amdfam10/northbridge.c
index dfa1316..1c1dcf4 100644
--- a/src/northbridge/amd/amdfam10/northbridge.c
+++ b/src/northbridge/amd/amdfam10/northbridge.c
@@ -111,7 +111,7 @@ static void f1_write_config32(unsigned reg, u32 value)
}
}
-static u32 amdfam10_nodeid(device_t dev)
+u32 amdfam10_nodeid(device_t dev)
{
#if NODE_NUMS == 64
unsigned busn;
@@ -176,7 +176,6 @@ static u32 amdfam10_scan_chain(device_t dev, u32 nodeid, struct bus *link, bool
int i;
- u32 ht_c_index;
u32 ht_unitid_base[4]; // here assume only 4 HT device on chain
u32 max_devfn;
@@ -188,9 +187,8 @@ static u32 amdfam10_scan_chain(device_t dev, u32 nodeid, struct bus *link, bool
/* See if there is an available configuration space mapping
* register in function 1.
*/
- ht_c_index = get_ht_c_index(nodeid, link->link_num, &sysconf);
-
- if(ht_c_index>=4) return max;
+ if (get_ht_c_index(link) >= 4)
+ return max;
/* Set up the primary, secondary and subordinate bus numbers.
* We have no idea how many busses are behind this bridge yet,
@@ -218,8 +216,7 @@ static u32 amdfam10_scan_chain(device_t dev, u32 nodeid, struct bus *link, bool
ht_route_link(link);
/* set the config map space */
-
- set_config_map_reg(nodeid, link->link_num, ht_c_index, link->secondary, link->subordinate, sysconf.segbit, sysconf.nodes);
+ set_config_map_reg(link);
/* Now we can scan all of the subordinate busses i.e. the
* chain on the hypertranport link
@@ -239,26 +236,22 @@ static u32 amdfam10_scan_chain(device_t dev, u32 nodeid, struct bus *link, bool
/* We know the number of busses behind this bridge. Set the
* subordinate bus number to it's real value
*/
- if(ht_c_index>3) { // clear the extend reg
- clear_config_map_reg(nodeid, link->link_num, ht_c_index, (max+1)>>sysconf.segbit, (link->subordinate)>>sysconf.segbit, sysconf.nodes);
- }
-
link->subordinate = max;
- set_config_map_reg(nodeid, link->link_num, ht_c_index, link->secondary, link->subordinate, sysconf.segbit, sysconf.nodes);
- sysconf.ht_c_num++;
- {
- // use ht_unitid_base to update hcdn_reg
- u32 temp = 0;
- for(i=0;i<4;i++) {
- temp |= (ht_unitid_base[i] & 0xff) << (i*8);
- }
+ if (0) {
+ /* Clear the extend reg. */
+ clear_config_map_reg(link);
+ }
- sysconf.hcdn_reg[ht_c_index] = temp;
+ set_config_map_reg(link);
- }
- store_ht_c_conf_bus(nodeid, link->link_num, ht_c_index, link->secondary, link->subordinate, &sysconf);
- return max;
+ /* Use ht_unitid_base to update hcdn_reg. */
+ link->hcdn_reg = 0;
+ for (i = 0; i < 4;i++)
+ link->hcdn_reg |= (ht_unitid_base[i] & 0xff) << (i*8);
+
+ store_ht_c_conf_bus(link);
+ return max;
}
static unsigned amdfam10_scan_chains(device_t dev, unsigned max)
More information about the coreboot-gerrit
mailing list