[coreboot-gerrit] New patch to review for coreboot: a9f65af northbridge/amd/amdmct: Honor MMCONF_BASE_ADDRESS
Timothy Pearson (tpearson@raptorengineeringinc.com)
gerrit at coreboot.org
Thu Jun 4 20:37:00 CEST 2015
Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10427
-gerrit
commit a9f65af84c145b426825644e2fd7c384cdbbd4cf
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date: Thu Jun 4 13:34:23 2015 -0500
northbridge/amd/amdmct: Honor MMCONF_BASE_ADDRESS
The MMIO hole start address was hardcoded on AMD Family 10h
systems. Use the MMCONF_BASE_ADDRESS Kconfig setting instead.
Change-Id: I204e904d96d14e99529fa5e524fd73e6ea256dc0
Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
src/northbridge/amd/amdmct/wrappers/mcti_d.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/northbridge/amd/amdmct/wrappers/mcti_d.c b/src/northbridge/amd/amdmct/wrappers/mcti_d.c
index 1706fce..3c730af 100644
--- a/src/northbridge/amd/amdmct/wrappers/mcti_d.c
+++ b/src/northbridge/amd/amdmct/wrappers/mcti_d.c
@@ -159,17 +159,15 @@ static u16 mctGet_NVbits(u8 index)
//val = 1; /* enable */
break;
case NV_BottomIO:
-#if !CONFIG_GFXUMA
- val = 0xE0; /* address bits [31:24] */
-#elif CONFIG_GFXUMA
- val = 0xC0; /* address bits [31:24] */
-#endif
- break;
case NV_BottomUMA:
+ /* address bits [31:24] */
#if !CONFIG_GFXUMA
- val = 0xE0; /* address bits [31:24] */
+ val = (CONFIG_MMCONF_BASE_ADDRESS >> 24);
#elif CONFIG_GFXUMA
- val = 0xC0; /* address bits [31:24] */
+ #if CONFIG_MMCONF_BASE_ADDRESS < 0x21000000)
+ #error "MMCONF_BASE_ADDRESS is too small"
+ #endif
+ val = (CONFIG_MMCONF_BASE_ADDRESS - 0x20000000 >> 24);
#endif
break;
case NV_ECC:
More information about the coreboot-gerrit
mailing list