[coreboot-gerrit] New patch to review for coreboot: 78fcd6b device/device.c: Only print init line once
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Sun Jun 7 20:37:18 CEST 2015
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10455
-gerrit
commit 78fcd6bf4af18ccd2d1dc9b303cf32e843e2a947
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Sun Jun 7 20:28:17 2015 +0200
device/device.c: Only print init line once
Since commit 05294292 (device tree: track init times) there are two
lines printed for each init() call of a device.
[…]
CPU_CLUSTER: 0 init 12708 usecs
DOMAIN: 0000 init
DOMAIN: 0000 init 1 usecs
PCI: 00:00.0 init
Northbridge init
PCI: 00:00.0 init 2 usecs
PCI: 00:01.0 init
PCI: 00:01.0 init 1 usecs
PCI: 00:01.1 init
PCI: 00:01.1 init 1 usecs
PCI: 00:11.0 init
PCI: 00:11.0 init 1 usecs
PCI: 00:14.0 init
PCI: 00:14.0 init 1 usecs
PCI: 00:14.3 init
SB800 - Late.c - lpc_init - Start.
RTC Init
RTC: coreboot checksum invalid
SB800 - Late.c - lpc_init - End.
[…]
Fix this by making the line without the time dependent, if
`HAVE_MONOTONIC_TIMER` is not selected.
Note, `dev->ops->init(dev)` is now called before the output line.
Change-Id: I7132cd650911dba680f060d6073a5a09c879b24c
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
src/device/device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/device/device.c b/src/device/device.c
index 6bdeae1..d6e3902 100644
--- a/src/device/device.c
+++ b/src/device/device.c
@@ -1144,12 +1144,13 @@ static void init_dev(struct device *dev)
dev_path(dev->bus->dev), dev->bus->link_num);
}
- printk(BIOS_DEBUG, "%s init\n", dev_path(dev));
dev->initialized = 1;
dev->ops->init(dev);
#if CONFIG_HAVE_MONOTONIC_TIMER
printk(BIOS_DEBUG, "%s init %ld usecs\n", dev_path(dev),
stopwatch_duration_usecs(&sw));
+#else
+ printk(BIOS_DEBUG, "%s init\n", dev_path(dev));
#endif
}
}
More information about the coreboot-gerrit
mailing list