[coreboot-gerrit] Patch set updated for coreboot: ec/lenovo/h8: re-factor handling of power_management_beeps
Francis Rowe (info@gluglug.org.uk)
gerrit at coreboot.org
Sat Jun 13 02:50:56 CEST 2015
Francis Rowe (info at gluglug.org.uk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10531
-gerrit
commit c775c43a4f97a9934fb04bc5a3b9f77c7a9d45a4
Author: Francis Rowe <info at gluglug.org.uk>
Date: Fri Jun 12 23:10:52 2015 +0100
ec/lenovo/h8: re-factor handling of power_management_beeps
Change-Id: I189c5ce382e1a270d24b9b6e897358268b9a141d
Signed-off-by: Francis Rowe <info at gluglug.org.uk>
---
src/ec/lenovo/h8/h8.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index 46480f4..db8fa68 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -2,6 +2,7 @@
* This file is part of the coreboot project.
*
* Copyright (C) 2011 Sven Schnelle <svens at stackframe.org>
+ * Copyright (C) 2015 Francis Rowe <info at gluglug.org.uk>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -212,14 +213,14 @@ static void h8_enable(struct device *dev)
beepmask0 = conf->beepmask0;
beepmask1 = conf->beepmask1;
- if (conf->has_power_management_beeps
- && get_option(&val, "power_management_beeps") == CB_SUCCESS
- && val == 0) {
- beepmask0 = 0x00;
- beepmask1 = 0x00;
- }
-
if (conf->has_power_management_beeps) {
+ if (get_option(&val, "power_management_beeps") != CB_SUCCESS)
+ val = 1;
+ if (!val) {
+ beepmask0 = 0x00;
+ beepmask1 = 0x00;
+ }
+
if (get_option(&val, "low_battery_beep") != CB_SUCCESS)
val = 1;
if (val)
More information about the coreboot-gerrit
mailing list