[coreboot-gerrit] Patch set updated for coreboot: mainboard/lenovo/*: disable power management beeps by default
Francis Rowe (info@gluglug.org.uk)
gerrit at coreboot.org
Sat Jun 13 02:51:06 CEST 2015
Francis Rowe (info at gluglug.org.uk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10533
-gerrit
commit ec98825c7bf917a8d31641e46ab1a55c80c85f17
Author: Francis Rowe <info at gluglug.org.uk>
Date: Sat Jun 13 00:42:38 2015 +0100
mainboard/lenovo/*: disable power management beeps by default
It annoys most users, when these beeps occur. For example, if the
user is in a public library (or a meeting), they don't want these
beeps. Leave them configurable, but disable them by default.
Change-Id: Ic8ccaba31fcbb609768a1d34a911c74453dacb5f
Signed-off-by: Francis Rowe <info at gluglug.org.uk>
---
src/ec/lenovo/h8/h8.c | 4 ++--
src/mainboard/lenovo/t60/cmos.default | 4 ++--
src/mainboard/lenovo/x200/cmos.default | 4 ++--
src/mainboard/lenovo/x201/cmos.default | 4 ++--
src/mainboard/lenovo/x60/cmos.default | 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index db8fa68..df8c424 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -215,14 +215,14 @@ static void h8_enable(struct device *dev)
if (conf->has_power_management_beeps) {
if (get_option(&val, "power_management_beeps") != CB_SUCCESS)
- val = 1;
+ val = 0;
if (!val) {
beepmask0 = 0x00;
beepmask1 = 0x00;
}
if (get_option(&val, "low_battery_beep") != CB_SUCCESS)
- val = 1;
+ val = 0;
if (val)
beepmask0 |= 2;
else
diff --git a/src/mainboard/lenovo/t60/cmos.default b/src/mainboard/lenovo/t60/cmos.default
index 6adf85d..9085cce 100644
--- a/src/mainboard/lenovo/t60/cmos.default
+++ b/src/mainboard/lenovo/t60/cmos.default
@@ -17,5 +17,5 @@ wwan=Enable
trackpoint=Enable
fn_ctrl_swap=Disable
sticky_fn=Disable
-power_management_beeps=Enable
-low_battery_beep=Enable
+power_management_beeps=Disable
+low_battery_beep=Disable
diff --git a/src/mainboard/lenovo/x200/cmos.default b/src/mainboard/lenovo/x200/cmos.default
index 67b8920..53a1faf 100644
--- a/src/mainboard/lenovo/x200/cmos.default
+++ b/src/mainboard/lenovo/x200/cmos.default
@@ -11,6 +11,6 @@ wlan=Enable
trackpoint=Enable
fn_ctrl_swap=Disable
sticky_fn=Disable
-power_management_beeps=Enable
-low_battery_beep=Enable
+power_management_beeps=Disable
+low_battery_beep=Disable
sata_mode=AHCI
diff --git a/src/mainboard/lenovo/x201/cmos.default b/src/mainboard/lenovo/x201/cmos.default
index 29eb509..d5796b7 100644
--- a/src/mainboard/lenovo/x201/cmos.default
+++ b/src/mainboard/lenovo/x201/cmos.default
@@ -13,6 +13,6 @@ touchpad=Enable
trackpoint=Enable
fn_ctrl_swap=Disable
sticky_fn=Disable
-power_management_beeps=Enable
-low_battery_beep=Enable
+power_management_beeps=Disable
+low_battery_beep=Disable
sata_mode=AHCI
diff --git a/src/mainboard/lenovo/x60/cmos.default b/src/mainboard/lenovo/x60/cmos.default
index 0185e94..3792ea0 100644
--- a/src/mainboard/lenovo/x60/cmos.default
+++ b/src/mainboard/lenovo/x60/cmos.default
@@ -17,5 +17,5 @@ wwan=Enable
trackpoint=Enable
fn_ctrl_swap=Disable
sticky_fn=Disable
-power_management_beeps=Enable
-low_battery_beep=Enable
+power_management_beeps=Disable
+low_battery_beep=Disable
More information about the coreboot-gerrit
mailing list