[coreboot-gerrit] New patch to review for coreboot: pcengines apu1: Add ACPI devicetree annotations for leds and buttons.
Tobias Diedrich (ranma+coreboot@tdiedrich.de)
gerrit at coreboot.org
Sat Jun 13 14:15:54 CEST 2015
Tobias Diedrich (ranma+coreboot at tdiedrich.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10540
-gerrit
commit 067145dfa7f3f42fe1494c6607abeee0c5b4d37a
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date: Sat Jun 13 13:29:50 2015 +0200
pcengines apu1: Add ACPI devicetree annotations for leds and buttons.
Provide ACPI devices with devicetree-compatible annotations for the three leds
and the button of the APU1.
This will cause the Linux kernel to automatically load the gpio-leds and
gpio-keys-polled drivers.
See http://events.linuxfoundation.org/sites/events/files/slides/ACPI_vs_DT.pdf
and https://lwn.net/Articles/612062/ for some more information on how the
PRP0001 HID works.
To make this usable a Linux-side gpio driver for the amd chipset is also
required.
Change-Id: I956ee92d9d98ef27a83ccb30d314543bd8634f2c
Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
---
src/mainboard/pcengines/apu1/acpi/buttons.asl | 34 ++++++++++++++++
src/mainboard/pcengines/apu1/acpi/leds.asl | 58 +++++++++++++++++++++++++++
src/mainboard/pcengines/apu1/dsdt.asl | 2 +
3 files changed, 94 insertions(+)
diff --git a/src/mainboard/pcengines/apu1/acpi/buttons.asl b/src/mainboard/pcengines/apu1/acpi/buttons.asl
new file mode 100644
index 0000000..e3e56db
--- /dev/null
+++ b/src/mainboard/pcengines/apu1/acpi/buttons.asl
@@ -0,0 +1,34 @@
+Scope (\_SB.PCI0.SBUS)
+{
+ Device (BTNS)
+ {
+ Name (_HID, "PRP0001")
+
+ Name (_CRS, ResourceTemplate () {
+ GpioIo (Exclusive, PullUp, 0, 0, IoRestrictionInputOnly,
+ "\\_SB.PCI0.SBUS", 0, ResourceConsumer) {187}
+ })
+
+ Name (_DSD, Package () {
+ ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package () {
+ Package () {"compatible", Package () {"gpio-keys-polled"}},
+ Package () {"poll-interval", 100},
+ Package () {"autorepeat", 1}
+ }
+ })
+
+ Device (BTN0)
+ {
+ Name (_DSD, Package () {
+ ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package () {
+ // BTN_MISC/BTN_0 is 0x100 in linux/input.h
+ Package () {"linux,code", 256},
+ Package () {"linux,input-type", 1},
+ Package () {"gpios", Package () {^^BTNS, 0, 0, 1 /* low-active */}},
+ }
+ })
+ }
+ }
+}
diff --git a/src/mainboard/pcengines/apu1/acpi/leds.asl b/src/mainboard/pcengines/apu1/acpi/leds.asl
new file mode 100644
index 0000000..8c14a63
--- /dev/null
+++ b/src/mainboard/pcengines/apu1/acpi/leds.asl
@@ -0,0 +1,58 @@
+Scope (\_SB.PCI0.SBUS)
+{
+ Device (LEDS)
+ {
+ Name (_HID, "PRP0001")
+
+ Name (_CRS, ResourceTemplate () {
+ GpioIo (Exclusive, PullUp, 0, 0, IoRestrictionOutputOnly,
+ "\\_SB.PCI0.SBUS", 0, ResourceConsumer) {189, 190, 191}
+ })
+
+ Name (_DSD, Package () {
+ ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package () {
+ Package () {"compatible", Package () {"gpio-leds"}},
+ }
+ })
+
+ Device (LED1)
+ {
+ Name (_DSD, Package () {
+ ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package () {
+ Package () {"label", "led1"},
+ Package () {"gpios", Package () {^^LEDS, 0, 0, 1 /* low-active */}},
+ Package () {"linux,default-trigger", "heartbeat"},
+ Package () {"linux,default-state", "keep"},
+ }
+ })
+ }
+
+ Device (LED2)
+ {
+ Name (_DSD, Package () {
+ ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package () {
+ Package () {"label", "led2"},
+ Package () {"gpios", Package () {^^LEDS, 0, 1, 1 /* low-active */}},
+ Package () {"linux,default-trigger", "phy0radio"},
+ Package () {"linux,default-state", "keep"},
+ }
+ })
+ }
+
+ Device (LED3)
+ {
+ Name (_DSD, Package () {
+ ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package () {
+ Package () {"label", "led3"},
+ Package () {"gpios", Package () {^^LEDS, 0, 2, 1 /* low-active */}},
+ Package () {"linux,default-trigger", "phy1radio"},
+ Package () {"linux,default-state", "keep"},
+ }
+ })
+ }
+ }
+}
diff --git a/src/mainboard/pcengines/apu1/dsdt.asl b/src/mainboard/pcengines/apu1/dsdt.asl
index 9358203..8f42e60 100644
--- a/src/mainboard/pcengines/apu1/dsdt.asl
+++ b/src/mainboard/pcengines/apu1/dsdt.asl
@@ -64,6 +64,8 @@ DefinitionBlock (
#include "acpi/sleep.asl"
#include "acpi/gpe.asl"
+ #include "acpi/leds.asl"
+ #include "acpi/buttons.asl"
#include <southbridge/amd/cimx/sb800/acpi/smbus.asl>
#include "acpi/thermal.asl"
}
More information about the coreboot-gerrit
mailing list