[coreboot-gerrit] New patch to review for coreboot: Reorder arch & vendorcode in Kconfig

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Sat Jun 20 06:31:06 CEST 2015


Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10609

-gerrit

commit 9e73733176c80a45449b97def4758e39eb3a707d
Author: Martin Roth <gaumless at gmail.com>
Date:   Fri Jun 19 22:30:43 2015 -0600

    Reorder arch & vendorcode in Kconfig
    
    Because Kconfig uses the first valid default that it comes across, the
    'source' commands to load sub-Kconfigs should be ordered from the
    most specific (mainboards) to less specific (chipsets) to least specific
    (architectures).  This allows the mainboards to override chipsets and
    architecture Kconfig files.
    
    Because the architecture files were getting loaded ahead of the chipset
    and cpu Kconfigs, the preferred defaults values for things such as
    NUM_IPI_STARTS or RISCV_BOOTBLOCK_CUSTOM could not be set.
    
    Change-Id: Ic327452833f012ec06dabb5b5ef661aba3aff464
    Signed-off-by: Martin Roth <gaumless at gmail.com>
---
 src/Kconfig | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/Kconfig b/src/Kconfig
index b7d2e67..c282d21 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -334,10 +334,6 @@ source "src/acpi/Kconfig"
 
 source "src/mainboard/Kconfig"
 
-source "src/arch/*/Kconfig"
-
-source "src/vendorcode/*/Kconfig"
-
 config SYSTEM_TYPE_LAPTOP
 	default n
 	bool
@@ -359,6 +355,9 @@ source "src/ec/acpi/Kconfig"
 source "src/ec/*/*/Kconfig"
 source "src/drivers/intel/fsp1_0/Kconfig"
 
+source "src/vendorcode/*/Kconfig"
+source "src/arch/*/Kconfig"
+
 endmenu
 
 source "src/device/Kconfig"



More information about the coreboot-gerrit mailing list