[coreboot-gerrit] New patch to review for coreboot: AMD/Hudson Makefile: Fill the ROMSIG with 0xFF instead of 0
Zheng Bao (zheng.bao@amd.com)
gerrit at coreboot.org
Wed Jun 24 09:42:46 CEST 2015
Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10651
-gerrit
commit 770f7664a013c2db9c753ea902e50a0e20b258b8
Author: zbao <fishbaozi at gmail.com>
Date: Wed Jun 17 18:51:42 2015 -0400
AMD/Hudson Makefile: Fill the ROMSIG with 0xFF instead of 0
Besides the first five DWORDs are used in ROMSIG, the offset
0x40 & 0x41 are used to save SPI settings. They should only
be 0xFF for being written.
Other parts in ROMSIG are also changed to 0xFF for potential
requirement.
Change-Id: I61ea8295d5ee8ffbbd0cfcf9e4bece770d70e1f2
Signed-off-by: Zheng Bao <zheng.bao at amd.com>
Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
---
src/southbridge/amd/pi/hudson/Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc
index ccca421..235ce1e 100644
--- a/src/southbridge/amd/pi/hudson/Makefile.inc
+++ b/src/southbridge/amd/pi/hudson/Makefile.inc
@@ -116,7 +116,7 @@ $(obj)/coreboot_hudson_romsig.bin: $(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM
$(call strip_quotes, $(CONFIG_HUDSON_GEC_FWM_FILE)) \
$(obj)/config.h
echo " Hudson FW $@"
- dd if=/dev/zero of=$@ count=$(ROMSIG_SIZE) ibs=1 status=noxfer 2>/dev/null; \
+ printf %d $(ROMSIG_SIZE) | LC_ALL=C awk '{for (i=0; i<$$1; i++) {printf "%c", 255}}' > $@; \
for fwm in 1437226410 \
$(HUDSON_IMC_POSITION) \
$(HUDSON_GEC_POSITION) \
More information about the coreboot-gerrit
mailing list