[coreboot-gerrit] New patch to review for coreboot: getac/p470: Fix ACPI warnings
Martin Roth (gaumless@gmail.com)
gerrit at coreboot.org
Fri Jun 26 04:23:55 CEST 2015
Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10667
-gerrit
commit ceeef46c0feea1ea3ca953a764d0b97e147e154b
Author: Martin Roth <gaumless at gmail.com>
Date: Thu Jun 25 19:08:06 2015 -0600
getac/p470: Fix ACPI warnings
This is a fix for the warnings, not getting rid of possible mistakes.
I don't have a board to test this, but it builds without warnings now,
and, I believe, follows the INTENT of the original code.
The _MIN, _MAX and _INT fields are word wide fields, even when the
attempt is to access them as bytes. By using the address offsets
for _MIN and _MAX, and changing _INT back to a word, this issue is
avoided.
A better fix is probably something similar to:
commit e3abd3bf roda/rk886ex: Correct COMB irq reading / reduce warnings
Without a board to test this on, however, I'd prefer to keep the fix
more similar to the original code.
Change-Id: I268119c9c569cffde4dedb22fa29c3f623bd8e25
Signed-off-by: Martin Roth <gaumless at gmail.com>
---
src/mainboard/getac/p470/acpi/superio.asl | 32 ++++++++++++-------------------
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/src/mainboard/getac/p470/acpi/superio.asl b/src/mainboard/getac/p470/acpi/superio.asl
index cca32cd..bc0c10c 100644
--- a/src/mainboard/getac/p470/acpi/superio.asl
+++ b/src/mainboard/getac/p470/acpi/superio.asl
@@ -127,13 +127,11 @@ Device (SIO1)
Return(NONE)
}
- CreateByteField(RSRC,
- \_SB.PCI0.LPCB.SIO1.UAR1._CRS._IOA._MIN, IOLO)
+ CreateByteField(RSRC, 0x02, IOLO) // \_SB.PCI0.LPCB.SIO1.UAR1._CRS._IOB._MIN low byte
CreateByteField(RSRC, 0x03, IOHI) // Why?
- CreateByteField(RSRC,
- \_SB.PCI0.LPCB.SIO1.UAR1._CRS._IOA._MAX, IORL)
+ CreateByteField(RSRC, 0x04, IORL) // \_SB.PCI0.LPCB.SIO1.UAR2._CRS._IOB._MAX low byte
CreateByteField(RSRC, 0x05, IORH) // Why?
- CreateByteField(RSRC,
+ CreateWordField(RSRC,
\_SB.PCI0.LPCB.SIO1.UAR1._CRS._IRA._INT, IRQL)
Store (READ(0, 0x24, 0xff), Local0)
@@ -282,13 +280,11 @@ Device (SIO1)
Return(NONE)
}
- CreateByteField(RSRC,
- \_SB.PCI0.LPCB.SIO1.UAR2._CRS._IOB._MIN, IOLO)
+ CreateByteField(RSRC, 0x02, IOLO) // \_SB.PCI0.LPCB.SIO1.UAR2._CRS._IOB._MIN low byte
CreateByteField(RSRC, 0x03, IOHI)
- CreateByteField(RSRC,
- \_SB.PCI0.LPCB.SIO1.UAR2._CRS._IOB._MAX, IORL)
+ CreateByteField(RSRC, 0x04, IORL) // \_SB.PCI0.LPCB.SIO1.UAR2._CRS._IOB._MAX low byte
CreateByteField(RSRC, 0x05, IORH)
- CreateByteField(RSRC,
+ CreateWordField(RSRC,
\_SB.PCI0.LPCB.SIO1.UAR2._CRS._IRB._INT, IRQL)
Store (READ(0, 0x25, 0xff), Local0)
@@ -436,13 +432,11 @@ Device (SIO1)
Return(NONE)
}
- CreateByteField(RSRC,
- \_SB.PCI0.LPCB.SIO1.UAR3._CRS._IOA._MIN, IOLO)
+ CreateByteField(RSRC, 0x02, IOLO) // \_SB.PCI0.LPCB.SIO1.UAR3._CRS._IOA._MIN low byte
CreateByteField(RSRC, 0x03, IOHI) // Why?
- CreateByteField(RSRC,
- \_SB.PCI0.LPCB.SIO1.UAR3._CRS._IOA._MAX, IORL)
+ CreateByteField(RSRC, 0x04, IORL) // \_SB.PCI0.LPCB.SIO1.UAR3._CRS._IOA._MAX low byte
CreateByteField(RSRC, 0x05, IORH) // Why?
- CreateByteField(RSRC,
+ CreateWordField(RSRC,
\_SB.PCI0.LPCB.SIO1.UAR3._CRS._IRA._INT, IRQL)
Store (READ(0, 0x1b, 0xff), Local0)
@@ -588,13 +582,11 @@ Device (SIO1)
Return(NONE)
}
- CreateByteField(RSRC,
- \_SB.PCI0.LPCB.SIO1.UAR4._CRS._IOA._MIN, IOLO)
+ CreateByteField(RSRC, 0x02, IOLO) // \_SB.PCI0.LPCB.SIO1.UAR4._CRS._IOA._MIN low byte
CreateByteField(RSRC, 0x03, IOHI) // Why?
- CreateByteField(RSRC,
- \_SB.PCI0.LPCB.SIO1.UAR4._CRS._IOA._MAX, IORL)
+ CreateByteField(RSRC, 0x04, IORL) // \_SB.PCI0.LPCB.SIO1.UAR4._CRS._IOA._MAX low byte
CreateByteField(RSRC, 0x05, IORH) // Why?
- CreateByteField(RSRC,
+ CreateWordField(RSRC,
\_SB.PCI0.LPCB.SIO1.UAR4._CRS._IRA._INT, IRQL)
Store (READ(0, 0x1c, 0xff), Local0)
More information about the coreboot-gerrit
mailing list