[coreboot-gerrit] New patch to review for coreboot: UDC: Correct cleaning out memory for string descriptors
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Mon Jun 29 16:41:11 CEST 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10687
-gerrit
commit fd47b009b7be90465ba2bc389964204cfccbd7d8
Author: Furquan Shaikh <furquan at google.com>
Date: Tue Jun 23 12:33:53 2015 -0700
UDC: Correct cleaning out memory for string descriptors
BUG=chrome-os-partner:41687
BRANCH=None
TEST=Compiles successfully and fastboot devices reports correct serial
number even after re-connection.
Change-Id: I4741a5d6333523eb47c27b4a20c4ef3f1e853d76
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: 6249b1e35391550d788f56a7b3e7a49ae19f0c93
Original-Change-Id: I1348c33f354d11e3c29ccd9da9948cfbeb60aa9e
Original-Signed-off-by: Furquan Shaikh <furquan at google.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/281192
Original-Trybot-Ready: Furquan Shaikh <furquan at chromium.org>
Original-Tested-by: Furquan Shaikh <furquan at chromium.org>
Original-Reviewed-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Queue: Furquan Shaikh <furquan at chromium.org>
---
payloads/libpayload/drivers/udc/udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/drivers/udc/udc.c b/payloads/libpayload/drivers/udc/udc.c
index 01aa4b1..834a891 100644
--- a/payloads/libpayload/drivers/udc/udc.c
+++ b/payloads/libpayload/drivers/udc/udc.c
@@ -350,7 +350,7 @@ static int setup_ep0(struct usbdev_ctrl *this, dev_req_t *dr)
int d_len = s_len * 2;
uint8_t *data = dma_malloc(d_len + 2);
- memset(data, 0, d_len);
+ memset(data, 0, d_len + 2);
data[0] = d_len + 2; // length
data[1] = 0x03; // string descriptor
int i;
More information about the coreboot-gerrit
mailing list