[coreboot-gerrit] Patch set updated for coreboot: 21f1ed4 AMD fam14: Blacklist Intel Centrino n6235 from PCIe ASPM

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Wed May 13 22:24:00 CEST 2015


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8496

-gerrit

commit 21f1ed489ec00b401cfd83b20ac7077fda7dc4e9
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Feb 16 09:41:39 2015 +0200

    AMD fam14: Blacklist Intel Centrino n6235 from PCIe ASPM
    
    PCI device ID of this mini-PCI-e WLAN card is 8086:088e.
    
    With this card inserted on pcengines/apu1 mini-PCI-e slot J17,
    system halts late in ramstage, in agesawrapper AMD_INIT_MID.
    
    Offending operation is enabling PCIe ASPM L0s and L1 for the card.
    That is, writing PCIe capability block Link Control [1:0] = 11b
    in the card's configuration space. AGESA already has a blacklist
    for the purpose of masking such unstable ASPM implementations.
    
    Change-Id: I9623699c4ee68e5cdc244b87faf92303b01c4823
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 .../agesa/f14/Proc/GNB/Modules/GnbPcieInitLibV1/PcieAspmBlackList.c    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbPcieInitLibV1/PcieAspmBlackList.c b/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbPcieInitLibV1/PcieAspmBlackList.c
index 0c22d25..8a10a27 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbPcieInitLibV1/PcieAspmBlackList.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbPcieInitLibV1/PcieAspmBlackList.c
@@ -95,7 +95,8 @@ UINT16  AspmBrDeviceTable[] = {
  0x10DE, 0x0392, (UINT16) ~(AspmL1 | AspmL0s),
  0x168C, 0xFFFF, (UINT16) ~(AspmL0s),
  0x1B4B, 0x91A3, (UINT16) ~(AspmL0s),
- 0x1B4B, 0x9123, (UINT16) ~(AspmL0s)
+ 0x1B4B, 0x9123, (UINT16) ~(AspmL0s),
+ 0x8086, 0x088e, (UINT16) ~(AspmL1 | AspmL0s),
 };
 
 /*----------------------------------------------------------------------------------------*/



More information about the coreboot-gerrit mailing list