[coreboot-gerrit] Patch set updated for coreboot: mainboard/asus/m2n-e|msi/ms9282: Clean up FIDVID mistakes
Timothy Pearson (tpearson@raptorengineeringinc.com)
gerrit at coreboot.org
Wed Oct 28 23:05:54 CET 2015
Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12226
-gerrit
commit 95beb4dcb1d3f45d7a5e1ca66e476d2f0c402779
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date: Wed Oct 28 15:29:29 2015 -0500
mainboard/asus/m2n-e|msi/ms9282: Clean up FIDVID mistakes
These two mainboards contained trivial mistakes related
to FIDVID that broke build when FIDVID was enabled.
Change-Id: Ie7bec77f26ec37eada21308984db4a9fd7a1866f
Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
src/mainboard/asus/m2n-e/romstage.c | 8 +++++++-
src/mainboard/msi/ms9282/romstage.c | 9 +++++++--
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/src/mainboard/asus/m2n-e/romstage.c b/src/mainboard/asus/m2n-e/romstage.c
index 306c124..aa3ea8d 100644
--- a/src/mainboard/asus/m2n-e/romstage.c
+++ b/src/mainboard/asus/m2n-e/romstage.c
@@ -65,9 +65,15 @@ static inline int spd_read_byte(unsigned int device, unsigned int address)
#include <southbridge/nvidia/mcp55/early_setup_ss.h>
#include "southbridge/nvidia/mcp55/early_setup_car.c"
#include "cpu/amd/model_fxx/init_cpus.c"
-#include "cpu/amd/model_fxx/fidvid.c"
#include "northbridge/amd/amdk8/early_ht.c"
+/* FIXME
+ * Dummy method to allow build
+ * Determine if this board / CPU should support
+ * FID/VID and implement proper support if so
+ */
+void init_fidvid_ap(u32 bsp_apicid, u32 apicid) { }
+
static void sio_setup(void)
{
u8 byte;
diff --git a/src/mainboard/msi/ms9282/romstage.c b/src/mainboard/msi/ms9282/romstage.c
index f5b75cc..b355f9e 100644
--- a/src/mainboard/msi/ms9282/romstage.c
+++ b/src/mainboard/msi/ms9282/romstage.c
@@ -81,10 +81,15 @@ static inline int spd_read_byte(unsigned device, unsigned address)
#include "southbridge/nvidia/mcp55/early_setup_car.c"
#include "cpu/amd/model_fxx/init_cpus.c"
-// Disabled until it's actually used:
-// #include "cpu/amd/model_fxx/fidvid.c"
#include "northbridge/amd/amdk8/early_ht.c"
+/* FIXME
+ * Dummy method to allow build
+ * Determine if this board / CPU should support
+ * FID/VID and implement proper support if so
+ */
+void init_fidvid_ap(u32 bsp_apicid, u32 apicid) { }
+
static void sio_setup(void)
{
uint32_t dword;
More information about the coreboot-gerrit
mailing list