[coreboot-gerrit] New patch to review for coreboot: amd/geode_lx: make done_cache_as_ram_main global

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Fri Sep 4 21:08:40 CET 2015


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11511

-gerrit

commit b45ca02849a8ffd15b9a4db490961577526598ee
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Sep 4 15:55:27 2015 -0500

    amd/geode_lx: make done_cache_as_ram_main global
    
    Current code written in C is calling a function implemented
    in assembly. However, the symbol's visibility is not set
    for such usage. Of course this works because MAINBOARDDIR/romstage.c
    is being processed into an assembly file currently.
    
    BUG=chrome-os-partner:44827
    BRANCH=None
    TEST=Built digitallogic/msm800sev while not changing romstage.c
         into an assembly file.
    
    Change-Id: I84c3af0026f3f98bc64af007aa7cc196429f4e5f
    Signed-off-by: Aaron Durbin <adubin at chromium.org>
---
 src/cpu/amd/geode_lx/cache_as_ram.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/cpu/amd/geode_lx/cache_as_ram.inc b/src/cpu/amd/geode_lx/cache_as_ram.inc
index bcb0d4b..11eda54 100644
--- a/src/cpu/amd/geode_lx/cache_as_ram.inc
+++ b/src/cpu/amd/geode_lx/cache_as_ram.inc
@@ -186,6 +186,7 @@ DCacheSetupGood:
 
 	/* Call romstage.c main function */
 	call	main
+.global done_cache_as_ram_main
 done_cache_as_ram_main:
 
 	/* We now run over the stack-in-cache,



More information about the coreboot-gerrit mailing list