[coreboot-gerrit] New patch to review for coreboot: rmodtool: honor ELF entry point

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Sat Sep 5 18:18:44 CET 2015


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11518

-gerrit

commit e8e0e7d0433385f43118c3d277083a5618dfc928
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Sat Sep 5 13:17:25 2015 -0500

    rmodtool: honor ELF entry point
    
    Instead of using a pre-determined symbol, _start, use
    the entry point within the ELF header.
    
    BUG=chrome-os-partner:44827
    BRANCH=None
    TEST=Built rambi and analyzed the relocatable ramstage,
         sipi_vector, and smm rmodules.
    
    Change-Id: I53e9c6eaa1ce761ab8519677fe2f4d0d2b82bb40
    Signed-off-by: Aaron Durbin <adubin at chromium.org>
---
 util/cbfstool/rmodule.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/util/cbfstool/rmodule.c b/util/cbfstool/rmodule.c
index 3b127b2..c35eff7 100644
--- a/util/cbfstool/rmodule.c
+++ b/util/cbfstool/rmodule.c
@@ -416,8 +416,8 @@ static int populate_program_info(struct rmod_context *ctx)
 	if (populate_sym(ctx, "_ebss", &ctx->bss_end, nsyms, strtab))
 		return -1;
 
-	if (populate_sym(ctx, "_start", &ctx->entry, nsyms, strtab))
-		return -1;
+	/* Honor the entry point within the ELF header. */
+	ctx->entry = ehdr->e_entry;
 
 	/* Link address is the virtual address of the program segment. */
 	ctx->link_addr = ctx->phdr->p_vaddr;



More information about the coreboot-gerrit mailing list