[coreboot-gerrit] New patch to review for coreboot: skylake: Remove dead code
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Mon Sep 7 18:42:25 CET 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11544
-gerrit
commit c139a3472626ae654862b32ad6c75f275696412e
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date: Thu Aug 20 19:04:31 2015 -0700
skylake: Remove dead code
Remove dead code not called by any part of coreboot.
BRANCH=none
BUG=None
TEST=Build and run on skylake
Change-Id: I3d457a196d12d03340bceb444d1d6c95afef13df
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: 58ea135813afeef773f37023fda58f36d544beef
Original-Change-Id: Id8f4591f20d41f875348c6583618bbcaaf9d9a3a
Original-Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/294953
Original-Commit-Ready: Leroy P Leahy <leroy.p.leahy at intel.com>
Original-Tested-by: Leroy P Leahy <leroy.p.leahy at intel.com>
Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
src/soc/intel/skylake/include/soc/romstage.h | 1 -
src/soc/intel/skylake/romstage/spi.c | 20 --------------------
2 files changed, 21 deletions(-)
diff --git a/src/soc/intel/skylake/include/soc/romstage.h b/src/soc/intel/skylake/include/soc/romstage.h
index f030301..d1c846b 100644
--- a/src/soc/intel/skylake/include/soc/romstage.h
+++ b/src/soc/intel/skylake/include/soc/romstage.h
@@ -33,7 +33,6 @@ void intel_early_me_status(void);
void enable_smbus(void);
int smbus_read_byte(unsigned device, unsigned address);
-int early_spi_read(u32 offset, u32 size, u8 *buffer);
int early_spi_read_wpsr(u8 *sr);
void mainboard_fill_spd_data(struct pei_data *pei_data);
diff --git a/src/soc/intel/skylake/romstage/spi.c b/src/soc/intel/skylake/romstage/spi.c
index 2194d21..41a144b 100644
--- a/src/soc/intel/skylake/romstage/spi.c
+++ b/src/soc/intel/skylake/romstage/spi.c
@@ -21,26 +21,6 @@
#include <soc/flash_controller.h>
#include <soc/romstage.h>
-int early_spi_read(u32 offset, u32 size, u8 *buffer)
-{
- u32 current = 0;
-
- spi_init();
- while (size > 0) {
- u8 count = (size < 64) ? size : 64;
- /* sending NULL for spiflash struct parameter since we are not
- * calling HWSEQ read() call via Probe.
- */
- if (pch_hwseq_read(NULL, offset + current, count,
- buffer + current) != 0)
- return -1;
- size -= count;
- current += count;
- }
-
- return 0;
-}
-
/*
* Minimal set of commands to read WPSR from SPI.
* Returns 0 on success, < 0 on failure.
More information about the coreboot-gerrit
mailing list